From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?S=C5=82awomir?= Grochowski Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) Date: Mon, 15 Apr 2024 14:39:15 +0200 Message-ID: <87wmoy94wc.fsf@gmail.com> References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> <87plv02rez.fsf@posteo.net> <87cyqzllbx.fsf@gmail.com> <87o7ahmxnj.fsf@posteo.net> <87msq12blu.fsf@gmail.com> <87cyqwmmkb.fsf@posteo.net> <87v84l3bfx.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14981"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 15 14:40:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwLdM-0003iR-EU for ged-emacs-devel@m.gmane-mx.org; Mon, 15 Apr 2024 14:40:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwLcP-0008L0-Sc; Mon, 15 Apr 2024 08:39:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwLcM-0008KR-Ae; Mon, 15 Apr 2024 08:39:27 -0400 Original-Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwLcK-0000Py-0N; Mon, 15 Apr 2024 08:39:26 -0400 Original-Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a523dad53e0so377648966b.1; Mon, 15 Apr 2024 05:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713184761; x=1713789561; darn=gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZEx75zVl/MTAjWfmH75WVlvoGUo/XsHda3ED4P45KZU=; b=X/QsEXjxv6aAeRFEcPVvYln2rNmr3kHACCogDpqu48C86joO45edENbEI7CnahH2TY m30lSVvwSB8JMIzjjEmrRpsrjVdmqkM53uLtzvop2Xxj6Cj79dYpgYihkfhlbbh/B4dL bompKrpvSbOViZY5ruVgTnaS0xuVaYIySAsLa42ahqxYR+kVtj3woTvy4AOXqHGUCcID UdElL3yH+VGYrz72DKjK/tYBzHfp3v528ALwgBprQweJUE7tpnsioGnWl80XjeDeQ+OO XbK+1Ag05dN3ITPoIlc+fHjSwos7D1NULflingNHYISfgjaXP0Yz4hEnOFI1oz3bWwYY Jrjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713184761; x=1713789561; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZEx75zVl/MTAjWfmH75WVlvoGUo/XsHda3ED4P45KZU=; b=Zb8e11AyuQZuI71zhKlhHNppaPSXpSx4GWjke5JLeRt/LBU06YajU/ZYVeXHs+2/wG WJfadLLQeUzb0qQnbro6mP4x+kTvtie80BDJEfc3mDcStnJf/Y7rYcruB614eDggEOqk If2xs8l7mE3gvNBrQHiF+2zZVceI0lU1YdUjOjENf3B1lQpcO8Gk5kxcFYXdLoPA/MAp bIiDSFE7Xbyi50DqoMFkKLWfv4lgpRnSz0FR76b3bcKVOZk/NkoRwVilrzoHCTW8GJ0e VXpI6ast6IFHs+HCVDJRUbh+LfhU2u8RpI0ACMMPm696RPLJmO1IK9NlIBFagt4hJwva 1I6Q== X-Forwarded-Encrypted: i=1; AJvYcCXoNTZtOX7U4grpzwQRZYeXBt7BJhDoVyh43VpsH2yietdQqHmGL8ZftmLWurKHC9r5KzJ/tRiwA2nPYKaEx79vgBf/XGYoRWTOzcONKgsFMZRbFaUAp0AxIaE= X-Gm-Message-State: AOJu0Yw8+xeYsnL9nKEKCUeLF/mfwnzWLblHiS5y06WHWcI1iHmV7U/a 8T64KlzmJsoX8BLmWCL9Z1HEsFYLe7oPIlk8WF8JsPR70pg3YHqzos/dbA== X-Google-Smtp-Source: AGHT+IH0TorAxlKGuuwwFKIDjflJEwL9+vRXnHTo0jtPezaeYkpPEyJpNfMr8UmXlnN1KWv+hQCjpA== X-Received: by 2002:a17:907:96a8:b0:a51:bea2:a6c4 with SMTP id hd40-20020a17090796a800b00a51bea2a6c4mr10240593ejc.29.1713184760635; Mon, 15 Apr 2024 05:39:20 -0700 (PDT) Original-Received: from windows (83.6.111.246.ipv4.supernova.orange.pl. [83.6.111.246]) by smtp.gmail.com with ESMTPSA id qf4-20020a1709077f0400b00a51e5813f4fsm5468875ejc.19.2024.04.15.05.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 05:39:20 -0700 (PDT) In-Reply-To: <87v84l3bfx.fsf@posteo.net> Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=slawomir.grochowski@gmail.com; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317735 gmane.emacs.orgmode:161061 Archived-At: Philip Kaludercic writes: > I have pushed the changes to master. Thank you Philip for your help. It works. But there is one more small thing. A message that is displayed in the minibuffer. It contains two pieces of information: (1) command name Right now it's hardcoded. We need to change the it from `help-quick-toggle' to `org-columns-help-quick-toggle'. How to do it? Add another variable like `help-quick-use-map'? Maybe 'help-quick-command-name'? (2) keybinding to the command name Just to modify message string. Add '\\'. To use other keymap. Change is in the diff below. diff --git a/lisp/help.el b/lisp/help.el index d4e39f04e53..35412b9d2fe 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -263,7 +263,9 @@ help-quick ;; ... and shrink it immediately. (fit-window-to-buffer)) (message - (substitute-command-keys "Toggle display of quick-help buffer using \\[help-quick-toggle].")))) + (substitute-command-keys "Toggle display of quick-help buffer using\\ \\[org-columns-help-quick-toggle].")))) + + (defun help-quick-toggle () "Toggle display of a window showing popular commands and their bindings. -- 2.30.2 Regards, -- Slawomir Grochowski