unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Michael Albinus <michael.albinus@gmx.de>,
	 emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 930c578c104: ; Improvements to PEG documentation
Date: Tue, 16 Apr 2024 17:33:38 -0700	[thread overview]
Message-ID: <87wmowltel.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <3800BF0D-113B-44B5-905E-A41B57E8BBB3@gmail.com> ("Mattias Engdegård"'s message of "Tue, 16 Apr 2024 12:05:44 +0200")

Mattias Engdegård <mattias.engdegard@gmail.com> writes:

> 16 apr. 2024 kl. 12.00 skrev Michael Albinus <michael.albinus@gmx.de>:
>
>> It looks, like the beginning of peg.texi has been removed accidently.
>
> I reverted the commit since it was such an obvious mistake. (Hope you don't mind.)

I certainly don't mind, thank you for coming to my rescue. I seem to be
slightly cursed recently.

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  emacs-devel@gnu.org
>> Date: Mon, 15 Apr 2024 20:18:56 -0700
>> 
>> 
>> On 04/14/24 07:58 AM, Eli Zaretskii wrote:
>> >> From: Stefan Monnier <monnier@iro.umontreal.ca>
>> >> Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,  emacs-devel@gnu.org
>> >> Date: Sat, 13 Apr 2024 15:36:14 -0400
>> >> 
>> >> > Ping!  Eric, any progress with this?
>> >> 
>> >> I fixed the test failures.
>> >
>> > Thanks.
>> >
>> > Eric, this leaves the documentation-related comments in my message
>> > from 2 weeks ago; could you please take care of those?
>> 
>> Done! Thank you for the push, and thanks to Stefan for fixing the tests.
>> 
>> I hope the docs read a bit better now -- I've also removed the mention
>> that `peg-parse' could also accept a single list of PEXS, as I don't
>> think it can any more (and I don't think it needs to be *so* flexible as
>> all that).
>
> Thanks, but it looks like you made some editing mistake, which deleted
> too much of the text, so the commit was reverted.  Please take a look
> and fix as needed; I tried to figure out what you wanted to do, but
> couldn't, presumably because too much of the text was inadvertently
> lost when you installed the changes.

I did delete quite a large chunk of text by accident, I've rewritten it
and committed again. Sorry this has been so rocky.

Eric



  reply	other threads:[~2024-04-17  0:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171323742013.5283.3736155251539337632@vcs2.savannah.gnu.org>
     [not found] ` <20240416031700.9D2B1C1FB45@vcs2.savannah.gnu.org>
2024-04-16 10:00   ` master 930c578c104: ; Improvements to PEG documentation Michael Albinus
2024-04-16 10:05     ` Mattias Engdegård
2024-04-17  0:33       ` Eric Abrahamsen [this message]
2024-04-17  2:38         ` Michael Heerdegen via Emacs development discussions.
2024-04-17  3:54           ` Eric Abrahamsen
2024-04-19 23:28             ` Eric Abrahamsen
2024-04-20 23:39               ` Michael Heerdegen via Emacs development discussions.
2024-04-21  0:51                 ` Eric Abrahamsen
2024-04-17 12:26         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmowltel.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=mattias.engdegard@gmail.com \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).