unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Morgan Willcock <morgan@ice9.digital>
To: emacs-devel@gnu.org
Subject: Accidental change of behaviour for electric-layout-mode?
Date: Mon, 23 Sep 2024 21:58:13 +0100	[thread overview]
Message-ID: <87wmj2dr4q.fsf@ice9.digital> (raw)

It looks like Emacs 30 is now allowing electric-layout-mode to insert
newlines inside comments and strings, whereas previous versions seem to
explicitly stop this from happening.

The commit that does it is b1f8d98a119ab8845d25d80c480cde6e385d8749
(Eglot: rework eglot-imenu) which doesn't mention electric-layout-mode
in the commit message or the associated bug report (58431).

I think it may have been done accidentally and is likely not a backwards
compatible change.

(I actually wanted the new behaviour and only found this because my
tests for newline insertion failed on Emacs 27, 28, and 29.  Making the
new behaviour opt-in would be nice, so I could send a patch to do that
if the previous change does look to have been accidental.)

Morgan

-- 
Morgan Willcock



             reply	other threads:[~2024-09-23 20:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23 20:58 Morgan Willcock [this message]
2024-09-24 11:23 ` Accidental change of behaviour for electric-layout-mode? Eli Zaretskii
2024-09-24 12:12   ` João Távora
2024-09-24 12:59     ` Eli Zaretskii
2024-09-24 18:59       ` Morgan Willcock
2024-09-24 19:03         ` Eli Zaretskii
2024-09-24 19:39           ` Morgan Willcock
2024-09-25 11:27             ` Eli Zaretskii
2024-09-25 13:50               ` Morgan Willcock
2024-09-25 15:57                 ` Eli Zaretskii
2024-10-03 16:22                   ` Morgan Willcock
2024-10-03 18:06                     ` Eli Zaretskii
2024-10-05 10:13                       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmj2dr4q.fsf@ice9.digital \
    --to=morgan@ice9.digital \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).