From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand Date: Tue, 03 Dec 2024 10:40:30 +0100 Message-ID: <87wmghcdf5.fsf@gmx.net> References: <173314163483.652988.2881826266893472321@vcs3.savannah.gnu.org> <20241202121355.3BF7D526A27@vcs3.savannah.gnu.org> <87plm9ybmc.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22613"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Michael Albinus , emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 10:41:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIPP6-0005iE-SV for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 10:41:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIPOb-0000wN-Sh; Tue, 03 Dec 2024 04:40:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIPOW-0000vF-G3 for emacs-devel@gnu.org; Tue, 03 Dec 2024 04:40:38 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIPOU-0004t7-MZ; Tue, 03 Dec 2024 04:40:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1733218831; x=1733823631; i=stephen.berman@gmx.net; bh=QTkqARcClfBv1zjltenH9P9frYBp2jbONUFF2vONH7c=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=bdmTdThSoJmfeFmj9AWo7EBLAaq+UVjTFmuGfnTENaczz9zU+9A/GDOFqX7WK18F X/PHfTHdg1O9JnaFnaqkYysgz09/CGogGjSI2cTdkLnyEg+RADKagkdL6sENwT4zo i5gqzDJHjnhbAlI0kOasK33KabRtInx1o8k73gyIAJKxQfwv8jhAXkj4FAeLdZpxL ygjg+QMnlkDB9CshRzwtoPazONv1j/2MpQw0KddHXUNfI/uBhN5yRR8fmMwplmJuT c5p+whRdFQCS6g8ILqePncKcFl5NJYyA5AxYr3295CTNv3VT5HhR4xgfuJyBrRuR1 YWGQG0lDfYubdIhSdQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfssd ([94.134.95.212]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49lJ-1tiube0Em9-00ufEG; Tue, 03 Dec 2024 10:40:31 +0100 In-Reply-To: (Andrea Corallo's message of "Tue, 03 Dec 2024 03:14:26 -0500") X-Provags-ID: V03:K1:u2yGhqagoOth5DbFEbXw03fEitMcuyO0FFWMaW9SD3c+yOsdb0M VFo9xBU4PVLEaohdf9qSa91Vu8QyBiB9QeCdiy2ZiQRPaWebTte2YGBbSNY0qtBs8sZOvbx bSabFbOYdIKQqHp7vUG/OLSuiRmhKFSFgiLnAbonKVarh9oxx1QkMI6mXluJjmdiY91sPl8 zg6Oh+W+2/U9ECodOrWlQ== UI-OutboundReport: notjunk:1;M01:P0:2c4ueFm92ac=;ZQaoQv9v80XEbQCdV03eiLJDhVW ntl5WBbm9bCc+nOntBD87ORUBQNLaIwg6/2nL7ctVZ3/VcnH2n59iBgawxokmU+2MTOIJpakT 3PDxgEwWSip0XT03MypTyuu13TNo/hrP2gSHxQVjM6ai9JASS9ezEcwlOSAuzkRAiDzeU5mpg d3YIAeo1pwJZopJs58VNa+lgxrVvFg9x0Yr4fVGILIRPJa+aM9wRw6BCImqoFqbSfAF/hlptT d08uN+eM1epYQaKNzhAD7ZFuf7XzuJIiEflS1d+DlIjpZZ346p0URxmbpdgZv9zpJzZgTlgPs 6/nAqx7VeMixj4ySjtkeGlCeU0Um4KaVEbNGpKEcMJwS+LxlLzf0PaTk2DyVDf0k6r1BGvdCq 4xZi+ur7iGSlT73w0WFfwt0MgZxYpPWzw7LkvMh+8tAPhqUhT5Nx4XnTHAcbZKjfAXIh3blmx ftzkIREdPghENBAtjjMbCEcCL2HLsTXRfLypv0ghmSnTcSB3ZZGl2UyKgRDrAZzI3ZvyDHTKB Xfi/CMypzuJ8XHc1z1rRjgbMYH2Gf6280gLUpAFsVJJjYJPO2WfE47Tca3AvtrSMJxo1TGwht 3cBL5oHpqNE02FOcy0TDMNqB4UlIdwtl9JNMU8g6f1IbQ//8A/GF4H5vODDuj8Qc11+OUAbe0 jRpGZzSYCGnSFziuPmaHMYlYoiUT6I+PHvr2pVxbtJrAJ6nXHbWBZu0rekBZAqT2q33VDOkbv E5JVrj8HbeVr97sePaOOIpfeAJL3kfMtKjD/yTZKjra1XsnqJhwCx2Qb10nSNXLtm5cUrX3S Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325978 Archived-At: On Tue, 03 Dec 2024 03:14:26 -0500 Andrea Corallo wrote: > Stephen Berman writes: > >> On Mon, 02 Dec 2024 15:45:23 -0500 Andrea Corallo wrote: >> >>> Stephen Berman via Mailing list for Emacs changes >>> writes: >>> >>>> branch: emacs-30 >>>> commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d >>>> Author: Stephen Berman >>>> Commit: Stephen Berman >>>> >>>> Fix latest test for dabbrev-expand >>>> >>>> * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer): >>>> Fix typo in a 'should' test, use part of return value of 'should-error' >>>> test, and remove mistaken and unfounded FIXME comment. >>> >>> Hello Stephen, >>> >>> this commit is introducing in my test-bed the following three failures >>> in emacs-30: dabbrev-expand-test-other-buffer-4, >>> dabbrev-expand-test-other-buffer-3, dabbrev-expand-after-killing-buffer. >>> Could you please have a look? >>> >>> Andrea >> >> How does your testbed run the tests? When I invoke `emacs-30 -batch -l >> ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el -f >> ert-run-tests-batch-and-exit' from the shell, all tests pass. Likewise, [...] > my testbench is running "make check -j24" on a fresh checkout on [...] On Tue, 03 Dec 2024 09:19:46 +0100 Michael Albinus wrote: [...] > dabbrev-tests.el is broken in the emacs-30 branch. Running 'make -C test > dabbrev-tests.log' yields the appended log file. It seems that substitute-command-keys applies to user-error messages in ert batch runs but not when executing `make check'. I missed the latter because when I committed that patch, the emacs-30 build was broken due to the librsvg version issue, so I couldn't run `make check'. But since `make check' had succeeded with my previous commit, I wrongly assumed it would also succeed this change; I should have waited. I've now pushed a workaround (commit 7b8d12e95de to emacs-30) with which both batch runs and `make check' succeed for me. Hopefully they do for everyone else too! Steve Berman