Re: emacs-30 6bca138d60e: Fix latest test for dabbrev-expand

[Stephen Berman <stephen.berman@gmx.net>]

On Tue, 03 Dec 2024 03:14:26 -0500 Andrea Corallo <acorallo@gnu.org> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> On Mon, 02 Dec 2024 15:45:23 -0500 Andrea Corallo <acorallo@gnu.org> wrote:
>>
>>> Stephen Berman via Mailing list for Emacs changes <emacs-diffs@gnu.org>
>>> writes:
>>>
>>>> branch: emacs-30
>>>> commit 6bca138d60e47d0fbab4faf8e83c5b9b319f260d
>>>> Author: Stephen Berman <stephen.berman@gmx.net>
>>>> Commit: Stephen Berman <stephen.berman@gmx.net>
>>>>
>>>>     Fix latest test for dabbrev-expand
>>>>
>>>>     * test/lisp/dabbrev-tests.el (dabbrev-expand-after-killing-buffer):
>>>>     Fix typo in a 'should' test, use part of return value of 'should-error'
>>>>     test, and remove mistaken and unfounded FIXME comment.
>>>
>>> Hello Stephen,
>>>
>>> this commit is introducing in my test-bed the following three failures
>>> in emacs-30: dabbrev-expand-test-other-buffer-4,
>>> dabbrev-expand-test-other-buffer-3, dabbrev-expand-after-killing-buffer.
>>> Could you please have a look?
>>>
>>>   Andrea
>>
>> How does your testbed run the tests?  When I invoke `emacs-30 -batch -l
>> ~/src/emacs/emacs-30/test/lisp/dabbrev-tests.el -f
>> ert-run-tests-batch-and-exit' from the shell, all tests pass.  Likewise,
[...]
> my testbench is running "make check -j24" on a fresh checkout on
[...]

On Tue, 03 Dec 2024 09:19:46 +0100 Michael Albinus <michael.albinus@gmx.de> wrote:

[...]
> dabbrev-tests.el is broken in the emacs-30 branch. Running 'make -C test
> dabbrev-tests.log' yields the appended log file.

It seems that substitute-command-keys applies to user-error messages in
ert batch runs but not when executing `make check'.  I missed the latter
because when I committed that patch, the emacs-30 build was broken due
to the librsvg version issue, so I couldn't run `make check'.  But since
`make check' had succeeded with my previous commit, I wrongly assumed it
would also succeed this change; I should have waited.  I've now pushed a
workaround (commit 7b8d12e95de to emacs-30) with which both batch runs
and `make check' succeed for me.  Hopefully they do for everyone else
too!

Steve Berman