Re: igc, macOS avoiding signals

[Helmut Eller <eller.helmut@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Fri, Jan 03 2025, Helmut Eller wrote:
[...]
> I'm not sure if those differences are acceptable.  I also have no good
> idea how to reduce it, except inserting more calls to maybe_quit.

It seems that calling maybe_quit before and after calling functions
would cure this problem.  With the original maybe_quit restored, as in
the attached patch, the foo example looks so:

    1986 100%         main
    1986 100%           record-samples
    1986 100%             foo
    1214  61%               float-time

Compared to the original

    1074  54%               float-time

that seems pretty ok.  Also the bar example

     812  80%                     animate-place-char
       6   0%                       window-start
      29   2%                       beginning-of-line
      29   2%                       delete-char
       6   0%                         undo-auto-amalgamate
      36   3%                       insert-char
     390  38%                       move-to-column
      11   1%                         undo-auto--undoable-change

looks quite good to me.

WDYT?



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Restore-maybe_quit-before-functions-are-called.patch --]
[-- Type: text/x-diff, Size: 1049 bytes --]

From 754efc2306682d882595c1b72022a877b0f415f8 Mon Sep 17 00:00:00 2001
From: Helmut Eller <eller.helmut@gmail.com>
Date: Sat, 4 Jan 2025 14:33:57 +0100
Subject: [PATCH] Restore maybe_quit before functions are called.

* src/bytecode.c (exec_byte_code): Call maybe_quite before pushing
a function.
---
 src/bytecode.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/bytecode.c b/src/bytecode.c
index 53c200e2c18..886be3e67f2 100644
--- a/src/bytecode.c
+++ b/src/bytecode.c
@@ -784,6 +784,7 @@ #define DEFINE(name, value) [name] = &&insn_ ## name,
 		  }
 	      }
 #endif
+	    maybe_quit ();
 
 	    if (++lisp_eval_depth > max_lisp_eval_depth)
 	      {
@@ -828,7 +829,8 @@ #define DEFINE(name, value) [name] = &&insn_ ## name,
 	    else
 	      val = funcall_general (original_fun, call_nargs, call_args);
 
-	    maybe_quit ();
+	    maybe_quit ();	/* needed for profiler */
+
 	    lisp_eval_depth--;
 	    if (backtrace_debug_on_exit (specpdl_ptr - 1))
 	      val = call_debugger (list2 (Qexit, val));
-- 
2.39.5


[-- Attachment #3: bar-3.report --]
[-- Type: text/plain, Size: 1416 bytes --]

       0   0% nil
    1007 100%   normal-top-level
    1007 100%     command-line
    1007 100%       command-line-1
    1007 100%         main
    1007 100%           record-samples
    1007 100%             bar
    1007 100%               animate-birthday-present
     999  99%                 animate-string
       5   0%                   sit-for
       5   0%                     sleep-for
      12   1%                   animate-initialize
     126  12%                   primitive-undo
      18   1%                     abs
     846  84%                   animate-step
     812  80%                     animate-place-char
       6   0%                       window-start
      29   2%                       beginning-of-line
      29   2%                       delete-char
       6   0%                         undo-auto-amalgamate
      36   3%                       insert-char
     390  38%                       move-to-column
      11   1%                         undo-auto--undoable-change
       8   0%                 capitalize
       8   0%                   load-with-code-conversion
       8   0%                     insert-file-contents
       8   0%                       set-auto-coding
       8   0%                         find-auto-coding
       8   0%                           auto-coding-regexp-alist-lookup
       8   0%                             re-search-forward
       0   0%   ...