From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Insert character pairs Date: Thu, 29 Apr 2004 18:02:53 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87vfjiakte.fsf@mail.jurta.org> References: <87brlb1840.fsf@mail.jurta.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1083252877 7794 80.91.224.253 (29 Apr 2004 15:34:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 29 Apr 2004 15:34:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Apr 29 17:34:18 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BJDYI-0006XG-00 for ; Thu, 29 Apr 2004 17:34:18 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BJDYH-0007oc-00 for ; Thu, 29 Apr 2004 17:34:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJDNr-0005dg-Ij for emacs-devel@quimby.gnus.org; Thu, 29 Apr 2004 11:23:31 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BJDME-0005AF-Iw for emacs-devel@gnu.org; Thu, 29 Apr 2004 11:21:50 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BJDLf-0004yi-Iq for emacs-devel@gnu.org; Thu, 29 Apr 2004 11:21:46 -0400 Original-Received: from [66.33.219.19] (helo=spoon.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BJD6Z-0002M6-MD for emacs-devel@gnu.org; Thu, 29 Apr 2004 11:05:39 -0400 Original-Received: from mail.jurta.org (80-235-36-125-dsl.mus.estpak.ee [80.235.36.125]) by spoon.dreamhost.com (Postfix) with ESMTP id 7181913D8BC; Thu, 29 Apr 2004 08:05:43 -0700 (PDT) Original-To: Stefan Monnier In-Reply-To: (Stefan Monnier's message of "29 Apr 2004 10:24:33 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22365 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22365 Stefan Monnier writes: >> The following patch generalizes the function `insert-parentheses' > > Why not start from skeleton-insert-paren-maybe ? It doesn't work with key modifiers. However, this could be partly fixed by replacing `last-command-char' with `(event-basic-type last-command-event)'. But still usage of function arguments of `skeleton-pair-insert-maybe' and `insert-parentheses' is very different: `skeleton-pair-insert-maybe' uses its argument to insert the typed character ARG times (which still doesn't work with modifiers), while `insert-parentheses' encloses ARG sexps in parentheses. I think the latter is better. But perhaps `skeleton-pair-insert-maybe' could be improved to interpret its argument like `insert-parentheses'? -- Juri Linkov http://www.jurta.org/emacs/