From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: new *Help* argument highlighting Date: Tue, 11 May 2004 03:07:07 +0300 Organization: JURTA Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <87vfj3kam4.fsf@mail.jurta.org> References: <20040510013534.F994.LEKTU@mi.madritel.es> <20040510020140.F99A.LEKTU@mi.madritel.es> <87llk0qftn.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1084240978 18669 80.91.224.253 (11 May 2004 02:02:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 May 2004 02:02:58 +0000 (UTC) Cc: bob@rattlesnake.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 11 04:02:51 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNMbb-0004Yj-00 for ; Tue, 11 May 2004 04:02:51 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNMba-0008Nl-00 for ; Tue, 11 May 2004 04:02:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNMZX-0006DB-OD for emacs-devel@quimby.gnus.org; Mon, 10 May 2004 22:00:43 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BNMYy-0006Bm-Ov for emacs-devel@gnu.org; Mon, 10 May 2004 22:00:08 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BNMOK-0004BK-10 for emacs-devel@gnu.org; Mon, 10 May 2004 21:49:42 -0400 Original-Received: from [66.33.219.4] (helo=spork.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNMMQ-0003kN-An for emacs-devel@gnu.org; Mon, 10 May 2004 21:47:10 -0400 Original-Received: from mail.jurta.org (80-235-39-207-dsl.mus.estpak.ee [80.235.39.207]) by spork.dreamhost.com (Postfix) with ESMTP id 9FE1511DC0F; Mon, 10 May 2004 18:47:07 -0700 (PDT) Original-To: Stefan Monnier In-Reply-To: <87llk0qftn.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "10 May 2004 15:06:13 -0400") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23100 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23100 Stefan Monnier writes: > As I said, I haven't seen a single complaint about the font-size change > in Info-mode in Emacs-21. Perhaps you haven't seen complaints about font sizes in Info-mode, because users who don't like that, has silently changed sizes in their .emacs files :-) > With the 6x13 font I use, "m" in bold looks basically like a solid block, > but I've never found it to be unreadable because it still looks clearly > different from all others (including "w"). > Is your situation similar except that the solid block does bother you > (maybe because you sight is not as good as mine)? This is clearly my situation with my 6x10 font, where the text displayed in this font is hardly readable. Even though I am able to guess from letter shapes and context what the text is displayed in bold, such constant guessing is too bothersome. And note, fr xmpl, tht vn wrds w/ vwls cn b rcgnzd, but this requires additional mental efforts. >> First, will someone who understands the patch review it? Or should I >> commit the merged version of xfaces.c and see whether it breaks others >> people's installations? > > My understanding of the patch is that it introduces risks of crashes. > If you set realize-face-filter-functions to functions that are simple > enough, it might be safe (tho maybe only if you compile with -DSYNC_INPUT). I tried this patch a month ago, but it often causes crashes. So without hope to get this patch working without crashes, I solved this particular problem with a small piece of code in .emacs: (add-to-list 'custom-define-hook 'my-faces-set) (defun my-faces-set (&optional frame) (interactive) ;; Check if this function is called by `custom-define-hook' from ;; `custom-declare-face' where the variable `face' is bound locally. (if (boundp 'face) (mapc (lambda (face) (when (face-bold-p face frame) (set-face-bold-p face nil frame) (set-face-underline-p face t frame)) (when (numberp (face-attribute face :height frame)) (set-face-attribute face frame :height 'unspecified)) (when (numberp (face-attribute face :width frame)) (set-face-attribute face frame :width 'unspecified))) (face-list)))) -- Juri Linkov http://www.jurta.org/emacs/