From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: lisp/recentf.el Date: Mon, 13 Jun 2005 15:52:07 +0200 Message-ID: <87vf4ie54o.fsf@xs4all.nl> References: <25526367.1118669753655.JavaMail.www@wwinf1534> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1118670900 18199 80.91.229.2 (13 Jun 2005 13:55:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2005 13:55:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 13 15:54:58 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DhpLG-0007MI-5R for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2005 15:51:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DhpQ2-0006vP-9Z for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2005 09:56:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DhpP2-0006eA-2n for emacs-devel@gnu.org; Mon, 13 Jun 2005 09:55:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DhpP0-0006d2-JH for emacs-devel@gnu.org; Mon, 13 Jun 2005 09:54:58 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DhpP0-0006cF-3L for emacs-devel@gnu.org; Mon, 13 Jun 2005 09:54:58 -0400 Original-Received: from [194.109.24.31] (helo=smtp-vbr11.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DhpNK-0005ou-JN for emacs-devel@gnu.org; Mon, 13 Jun 2005 09:53:14 -0400 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr11.xs4all.nl (8.13.3/8.13.3) with ESMTP id j5DDq7WU019409; Mon, 13 Jun 2005 15:52:08 +0200 (CEST) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1DhpMF-00010p-00; Mon, 13 Jun 2005 15:52:07 +0200 Original-To: david.ponce@wanadoo.fr In-Reply-To: <25526367.1118669753655.JavaMail.www@wwinf1534> (David PONCE's message of "Mon, 13 Jun 2005 15:35:53 +0200 (CEST)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 121 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38717 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38717 Hi David, >> Does someone see a problem with this change? > > This is a good idea, however I think the call to `recentf-dialog-mode' > should be moved before to setup the widgets because they might use > local variables. Like this? Lute. Index: lisp/recentf.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/recentf.el,v retrieving revision 1.37 diff -c -r1.37 recentf.el *** lisp/recentf.el 31 May 2005 04:19:10 -0000 1.37 --- lisp/recentf.el 13 Jun 2005 13:49:20 -0000 *************** *** 923,931 **** \\{recentf-dialog-mode-map}" (interactive) (setq major-mode 'recentf-dialog-mode) (setq mode-name "recentf-dialog") ! (use-local-map recentf-dialog-mode-map)) ;;; Hooks ;; --- 923,933 ---- \\{recentf-dialog-mode-map}" (interactive) + (kill-all-local-variables) (setq major-mode 'recentf-dialog-mode) (setq mode-name "recentf-dialog") ! (use-local-map recentf-dialog-mode-map) ! (run-mode-hooks 'recentf-dialog-mode-hook)) ;;; Hooks ;; *************** *** 1002,1014 **** (get-buffer-create (format "*%s - Edit list*" recentf-menu-title)) (switch-to-buffer (current-buffer)) ;; Cleanup buffer - (kill-all-local-variables) (let ((inhibit-read-only t) (ol (overlay-lists))) (erase-buffer) ;; Delete all the overlays. (mapc 'delete-overlay (car ol)) (mapc 'delete-overlay (cdr ol))) (setq recentf-edit-selected-items nil) ;; Insert the dialog header (widget-insert --- 1004,1016 ---- (get-buffer-create (format "*%s - Edit list*" recentf-menu-title)) (switch-to-buffer (current-buffer)) ;; Cleanup buffer (let ((inhibit-read-only t) (ol (overlay-lists))) (erase-buffer) ;; Delete all the overlays. (mapc 'delete-overlay (car ol)) (mapc 'delete-overlay (cdr ol))) + (recentf-dialog-mode) (setq recentf-edit-selected-items nil) ;; Insert the dialog header (widget-insert *************** *** 1045,1051 **** 'push-button :notify 'recentf-cancel-dialog "Cancel") - (recentf-dialog-mode) (widget-setup) (goto-char (point-min)))) --- 1047,1052 ---- *************** *** 1101,1113 **** (with-current-buffer (get-buffer-create buffer-name) (switch-to-buffer (current-buffer)) ;; Cleanup buffer - (kill-all-local-variables) (let ((inhibit-read-only t) (ol (overlay-lists))) (erase-buffer) ;; Delete all the overlays. (mapc 'delete-overlay (car ol)) (mapc 'delete-overlay (cdr ol))) ;; Insert the dialog header (widget-insert "Click on a file to open it. ") (widget-insert "Click on Cancel or type \"q\" to quit.\n\n" ) --- 1102,1114 ---- (with-current-buffer (get-buffer-create buffer-name) (switch-to-buffer (current-buffer)) ;; Cleanup buffer (let ((inhibit-read-only t) (ol (overlay-lists))) (erase-buffer) ;; Delete all the overlays. (mapc 'delete-overlay (car ol)) (mapc 'delete-overlay (cdr ol))) + (recentf-dialog-mode) ;; Insert the dialog header (widget-insert "Click on a file to open it. ") (widget-insert "Click on Cancel or type \"q\" to quit.\n\n" ) *************** *** 1123,1129 **** 'push-button :notify 'recentf-cancel-dialog "Cancel") - (recentf-dialog-mode) (widget-setup) (goto-char (point-min)))) --- 1124,1129 ----