From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: Darwin support for lisp/battery.el. Date: Sat, 02 Jul 2005 16:33:39 +0200 Message-ID: <87vf3tuvjw.fsf@xs4all.nl> References: <8764vtxusp.fsf@xs4all.nl> <85psu1gvx7.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1120316296 5023 80.91.229.2 (2 Jul 2005 14:58:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 2 Jul 2005 14:58:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 02 16:58:15 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DojRV-0006Fm-9m for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2005 16:58:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DojSc-00012j-3Z for ged-emacs-devel@m.gmane.org; Sat, 02 Jul 2005 10:59:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DojOw-000099-Ah for emacs-devel@gnu.org; Sat, 02 Jul 2005 10:55:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DojOl-0008Vd-TD for emacs-devel@gnu.org; Sat, 02 Jul 2005 10:55:17 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DojOk-0008Mj-Uz for emacs-devel@gnu.org; Sat, 02 Jul 2005 10:55:14 -0400 Original-Received: from [194.109.24.35] (helo=smtp-vbr15.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Doj9F-0004H6-07; Sat, 02 Jul 2005 10:39:13 -0400 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr15.xs4all.nl (8.13.3/8.13.3) with ESMTP id j62EXecq032031; Sat, 2 Jul 2005 16:33:40 +0200 (CEST) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1Doj3r-0006T3-00; Sat, 02 Jul 2005 16:33:39 +0200 Original-To: David Kastrup In-Reply-To: <85psu1gvx7.fsf@lola.goethe.zz> (David Kastrup's message of "Sat, 02 Jul 2005 15:49:24 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 25 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40118 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40118 David Kastrup writes: > Lute Kamstra writes: > >> Currently, lisp/battery.el supports only Linux. I've added support >> for Darwin. See the patch below. Is it ok to install this now, or >> should I wait until after the release? > > Can you get a tester base for most of the systems that would be > affected by this code? Does this code do anything if the mode is > not explicitly enabled? The systems that are affected by this change are those whose `system-type' is equal to darwin (and that have the "pmset" program available). What changes for the users of those systems is that they will be able to use display-battery-mode when they choose to do so. (That mode just didn't do anything for them previously.) display-battery-mode is not enabled by default. I don't use Darwin so I couldn't really test the code myself. Samuel Lauber was so kind to do that for me. I think there are quite some people with laptops running OS X and using CVS Emacs. So I guess that the code will get some decent testing when it is committed now. Lute.