From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Wrong common substring highlighted in Completion buffer Date: Sat, 10 Dec 2005 12:14:45 +0200 Organization: JURTA Message-ID: <87vexx1r63.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134219274 5781 80.91.229.2 (10 Dec 2005 12:54:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Dec 2005 12:54:34 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 10 13:54:32 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1El4EI-0000ef-MU for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2005 13:53:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1El4Eg-00043b-Pr for ged-emacs-devel@m.gmane.org; Sat, 10 Dec 2005 07:53:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1El3FZ-0001tz-58 for emacs-devel@gnu.org; Sat, 10 Dec 2005 06:50:49 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1El2JP-0007pS-HQ for emacs-devel@gnu.org; Sat, 10 Dec 2005 05:50:45 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1El2Bl-00072V-Eb for emacs-devel@gnu.org; Sat, 10 Dec 2005 05:42:49 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1El2D7-0000wO-BW for emacs-devel@gnu.org; Sat, 10 Dec 2005 05:44:13 -0500 Original-Received: from mail.neti.ee (80-235-32-231-dsl.mus.estpak.ee [80.235.32.231]) by Relayhost1.neti.ee (Postfix) with ESMTP id 34F721E9A for ; Sat, 10 Dec 2005 12:42:39 +0200 (EET) Original-To: emacs-devel@gnu.org User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47383 Archived-At: After typing `C-h f read-mini C-b C-b C-b C-b TAB' wrong common substrings are highlighted in the *Completions* buffer. The substring "read-mini" is highlighted, but really completion is performed on the substring "read-" before point in the minibuffer. The function returning the right minibuffer substring is minibuffer_completion_contents. I believe the following patch is correct. Index: src/minibuf.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/minibuf.c,v retrieving revision 1.294 diff -c -r1.294 minibuf.c *** src/minibuf.c 6 Dec 2005 15:53:58 -0000 1.294 --- src/minibuf.c 10 Dec 2005 10:10:42 -0000 *************** *** 2563,2569 **** display_completion_list_1 (list) Lisp_Object list; { ! return Fdisplay_completion_list (list, Qnil); } DEFUN ("minibuffer-completion-help", Fminibuffer_completion_help, Sminibuffer_completion_help, --- 2565,2571 ---- display_completion_list_1 (list) Lisp_Object list; { ! return Fdisplay_completion_list (list, minibuffer_completion_contents ()); } DEFUN ("minibuffer-completion-help", Fminibuffer_completion_help, Sminibuffer_completion_help, -- Juri Linkov http://www.jurta.org/emacs/