From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Fri, 16 Dec 2005 16:27:28 +0200 Organization: JURTA Message-ID: <87vexpuqbb.fsf@jurta.org> References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <36F6CF11-E742-4175-A995-E5A62EC2A335@gmail.com> <87psobhwo5.fsf@jurta.org> <87u0dl3gpy.fsf@jurta.org> <439D3397.1020404@swipnet.se> <439E75F8.4050201@swipnet.se> <877ja71vyq.fsf@jurta.org> <87irtpbata.fsf@jurta.org> <87d5jx6y1c.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1134760601 16795 80.91.229.2 (16 Dec 2005 19:16:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2005 19:16:41 +0000 (UTC) Cc: david.reitter@gmail.com, jan.h.d@swipnet.se, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 16 20:16:31 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EnL3Z-000513-Qo for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 20:15:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnL4H-0002X4-Mj for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 14:16:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EnGpd-000639-Vc for emacs-devel@gnu.org; Fri, 16 Dec 2005 09:45:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EnGo0-0005XE-UB for emacs-devel@gnu.org; Fri, 16 Dec 2005 09:43:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnGlk-0004aW-P9 for emacs-devel@gnu.org; Fri, 16 Dec 2005 09:41:12 -0500 Original-Received: from [194.126.101.111] (helo=mail.neti.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EnGnZ-0002Bu-Ia; Fri, 16 Dec 2005 09:43:05 -0500 Original-Received: from mail.neti.ee (80-235-37-37-dsl.mus.estpak.ee [80.235.37.37]) by Relayhost1.neti.ee (Postfix) with ESMTP id D3CA43841; Fri, 16 Dec 2005 16:40:06 +0200 (EET) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Fri, 16 Dec 2005 15:14:47 +0200") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-2.2.1 (20041222) (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47871 Archived-At: > FWIW, I don't like using the frame returned by selected-frame because > that could enable the menu items if menu-updating-frame is somehow not > set when it should. We might be sweeping problems under the carpet > here. If for some reason menu-updating-frame is not set when it should (due to a bug or a overlooked case) then it is much better to enable menu items than to disable them by default. When a menu item is enabled with its updating frame invisible, it is not a disaster. But when menu items are permanently disabled (for another overlooked case like non-toolkit builds), this makes menus in Emacs unusable. The change in menu-bar.el makes such an unfortunate situation impossible. -- Juri Linkov http://www.jurta.org/emacs/