From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Recent changes to regex.c break bootstrapping Date: Mon, 20 Feb 2006 12:08:38 -0500 Message-ID: <87veva3qll.fsf@stupidchicken.com> References: <200602200610.k1K6ANa25590@raven.dms.auburn.edu> <43F973F4.9060807@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140474970 25105 80.91.229.2 (20 Feb 2006 22:36:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2006 22:36:10 +0000 (UTC) Cc: Luc Teirlinck , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 20 23:36:08 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FBJdH-0003rz-1U for ged-emacs-devel@m.gmane.org; Mon, 20 Feb 2006 23:35:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FBJbW-0000kv-7A for ged-emacs-devel@m.gmane.org; Mon, 20 Feb 2006 17:34:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FBEuU-0004Ms-3i for emacs-devel@gnu.org; Mon, 20 Feb 2006 12:33:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FBEtx-0004Gr-NV for emacs-devel@gnu.org; Mon, 20 Feb 2006 12:32:47 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FBEWa-0005c3-4R for emacs-devel@gnu.org; Mon, 20 Feb 2006 12:08:36 -0500 Original-Received: from [18.95.6.7] (helo=outgoing.mit.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FBEce-0005WR-Ov for emacs-devel@gnu.org; Mon, 20 Feb 2006 12:14:52 -0500 Original-Received: by outgoing.mit.edu (Postfix, from userid 1000) id 5A9331E423B; Mon, 20 Feb 2006 12:08:38 -0500 (EST) Original-To: "Jan D." In-Reply-To: <43F973F4.9060807@swipnet.se> (Jan D.'s message of "Mon, 20 Feb 2006 08:47:00 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:50820 Archived-At: The 2006-02-19 change to regex.c, changing malloc and realloc to xmalloc and xrealloc, doesn't do what it is apparently supposed to do, since regex.c defines malloc as xmalloc, realloc as xrealloc, and free as xfree when linked with Emacs. For the case when it is not linked with Emacs, I added xmalloc and xrealloc definitions (no need for xfree, since its only purpose is to call BLOCK_INPUT), and put in the same malloc -> xmalloc, realloc -> xrealloc redefinitions. I hope this is correct way to go. One worry: if another non-Emacs-linked file #includes regex.c and defines its own xmalloc, ugliness may ensue.