unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: "Juanma Barranquero" <lekktu@gmail.com>
Cc: emacs-devel@gnu.org, Jason Rumney <jasonr@gnu.org>
Subject: Re: Image autodetection
Date: Tue, 30 Jan 2007 11:58:18 -0500	[thread overview]
Message-ID: <87veiotpsl.fsf@stupidchicken.com> (raw)
In-Reply-To: <f7ccd24b0701300411n3a943f1ehe59ca3a8646a33a8@mail.gmail.com> (Juanma Barranquero's message of "Tue\, 30 Jan 2007 13\:11\:55 +0100")

"Juanma Barranquero" <lekktu@gmail.com> writes:

> On 1/30/07, Juanma Barranquero <lekktu@gmail.com> wrote:
>
>> so I like Richard's idea of bypassing #1 of Chong's
>> proposals (no more options, please!) and just implementing #2 (with
>> image-toggle-display disabled, as you note).
>
> Something like the attached patch, which couldn't be simpler.

> -  (if (and (display-images-p)
> -	   (not (get-text-property (point-min) 'display)))
> -      (image-toggle-display)
> -    ;; Set next vars when image is already displayed but local
> -    ;; variables were cleared by kill-all-local-variables
> -    (setq cursor-type nil truncate-lines t))
> +  (setq cursor-type nil truncate-lines t)

This last line should not be present; its purpose was to hide the
cursor in case we are already displaying as an image and run
image-mode again.  I've checked in the patch, with this additional
correction.

  parent reply	other threads:[~2007-01-30 16:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 19:05 Image autodetection Chong Yidong
2007-01-29 19:19 ` Juanma Barranquero
2007-01-30  9:04   ` Jason Rumney
2007-01-30  9:38     ` Juanma Barranquero
2007-01-30 12:11       ` Juanma Barranquero
2007-01-30 15:24         ` Stefan Monnier
2007-01-30 15:59           ` Juanma Barranquero
2007-01-30 16:54             ` Jason Rumney
2007-01-30 17:07               ` Juanma Barranquero
2007-01-30 16:58         ` Chong Yidong [this message]
2007-01-29 23:53 ` Richard Stallman
2007-01-30  0:55 ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87veiotpsl.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).