23.0.50; `wdired-next-line' put point in column 0

23.0.50; `wdired-next-line' put point in column 0

[David Hansen]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]


Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello,

`wdired-next-line' puts point into column 0 (iff
`wdired-use-dired-vertical-movement' is nil), same with
`wdired-previous-line'.

The expected behavior would be like the one of `next-line' and
`previous-line'.  This was the case until some weeks (?) ago (did
`forward-line' changed?).

The attached patch fixes the problem.

David


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1595 bytes --]

Index: wdired.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wdired.el,v
retrieving revision 1.28
diff -c -r1.28 wdired.el
*** wdired.el	20 Oct 2007 06:30:16 -0000	1.28
--- wdired.el	28 Oct 2007 13:56:08 -0000
***************
*** 499,505 ****
  See `wdired-use-dired-vertical-movement'.  Optional prefix ARG
  says how many lines to move; default is one line."
    (interactive "p")
!   (forward-line arg)
    (if (or (eq wdired-use-dired-vertical-movement t)
  	  (and wdired-use-dired-vertical-movement
  	       (< (current-column)
--- 499,505 ----
  See `wdired-use-dired-vertical-movement'.  Optional prefix ARG
  says how many lines to move; default is one line."
    (interactive "p")
!   (next-line arg)
    (if (or (eq wdired-use-dired-vertical-movement t)
  	  (and wdired-use-dired-vertical-movement
  	       (< (current-column)
***************
*** 512,518 ****
  See `wdired-use-dired-vertical-movement'.  Optional prefix ARG
  says how many lines to move; default is one line."
    (interactive "p")
!   (forward-line (- arg))
    (if (or (eq wdired-use-dired-vertical-movement t)
  	  (and wdired-use-dired-vertical-movement
  	       (< (current-column)
--- 512,518 ----
  See `wdired-use-dired-vertical-movement'.  Optional prefix ARG
  says how many lines to move; default is one line."
    (interactive "p")
!   (previous-line arg)
    (if (or (eq wdired-use-dired-vertical-movement t)
  	  (and wdired-use-dired-vertical-movement
  	       (< (current-column)


Diffs between working revision and workfile end here.

[-- Attachment #3: Type: text/plain, Size: 2893 bytes --]





If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/home/dhansen/share/emacs/23.0.50/etc/DEBUG for instructions.


In GNU Emacs 23.0.50.1 (i686-pc-linux-gnu)
 of 2007-10-28 on robotron
Windowing system distributor `The X.Org Foundation', version 11.0.10400000
configured using `configure  '--prefix=/home/dhansen' '--disable-sound' '--disable-pop' '--with-x-toolkit=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Editable Dired

Minor modes in effect:
  TeX-PDF-mode: t
  jabber-activity-mode: t
  which-function-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  abbrev-mode: 1

Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <down> <down> 
C-k C-k C-k q g <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <down> <return> 
q <return> SPC SPC n = d d d d d d SPC SPC SPC d d 
q g <down> <down> <down> <down> <return> SPC <C-tab> 
<tab> C-c m SPC <tab> C-c m <switch-frame> <switch-frame> 
SPC <tab> <tab> <tab> <tab> C-c m SPC SPC SPC <tab> 
C-c m SPC <tab> C-c m SPC <tab> Y <C-tab> C-x 1 <down> 
<down> <down> <down> <down> <down> <up> <return> <C-tab> 
<tab> C-c m q C-x b f l <return> C-g C-x b f u l <return> 
C-x d ~ / s c <tab> <return> r C-n C-n C-n C-c C-c 
r C-h f C-g C-h k C-n <switch-frame> <switch-frame> 
<tab> <return> <switch-frame> <switch-frame> C-n C-n 
C-n C-n C-l C-u C-x C-g C-u C-x C-g C-u C-M-x <C-tab> 
C-n n n n n n n n n n n C-e C-n n n n n n n n n n <C-tab> 
C-n M-f C-h f <return> C-h k C-n C-c SPC C-h f <return> 
M-: ( f o r e a <backspace> <backspace> w a r d - l 
i n e SPC 1 C-e <return> <C-tab> M-x r e p o r t - 
e m a c s - b u g <tab> <return>

Recent messages:
Result: 0 (#o0, #x0, ?\C-@)
Result: nil [6 times]
Reading 197 bytes...
Text is read-only
Result: 1 (#o1, #x1, ?\C-a)
Result: 0 (#o0, #x0, ?\C-@)
Result: nil [6 times]
Auto-saving...done
0 (#o0, #x0)
Scanning for dabbrevs...100%

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: 23.0.50; `wdired-next-line' put point in column 0

[martin rudalics]

> `wdired-next-line' puts point into column 0 (iff
> `wdired-use-dired-vertical-movement' is nil), same with
> `wdired-previous-line'.
> 
> The expected behavior would be like the one of `next-line' and
> `previous-line'.  This was the case until some weeks (?) ago (did
> `forward-line' changed?).
> 
> The attached patch fixes the problem.

Thanks for reporting.  I checked in a fix that doesn't create
byte-compiler warnings.