* doc-view.el: make-directory (was: Changes to emacs/lisp/doc-view.el, v)
[not found] <E1JZrtx-0003NZ-Sa@cvs.savannah.gnu.org>
@ 2008-03-13 22:24 ` Reiner Steib
2008-03-14 13:23 ` doc-view.el: make-directory Tassilo Horn
0 siblings, 1 reply; 3+ messages in thread
From: Reiner Steib @ 2008-03-13 22:24 UTC (permalink / raw)
To: Tassilo Horn; +Cc: emacs-devel
On Thu, Mar 13 2008, Tassilo Horn on emacs-diffs:
> --- doc-view.el 12 Mar 2008 15:26:48 -0000 1.56
> +++ doc-view.el 13 Mar 2008 18:11:37 -0000 1.57
> @@ -600,7 +600,8 @@
>
> (defun doc-view-doc->txt (txt callback)
> "Convert the current document to text and call CALLBACK when done."
> - (make-directory (doc-view-current-cache-dir))
> + (unless (file-exists-p (doc-view-current-cache-dir))
> + (make-directory (doc-view-current-cache-dir)))
Wouldn't using non-nil `parents' be a more simple solution?
(make-directory (doc-view-current-cache-dir) t)
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: doc-view.el: make-directory
2008-03-13 22:24 ` doc-view.el: make-directory (was: Changes to emacs/lisp/doc-view.el, v) Reiner Steib
@ 2008-03-14 13:23 ` Tassilo Horn
2008-03-16 9:25 ` Tassilo Horn
0 siblings, 1 reply; 3+ messages in thread
From: Tassilo Horn @ 2008-03-14 13:23 UTC (permalink / raw)
To: emacs-devel
Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> --- doc-view.el 12 Mar 2008 15:26:48 -0000 1.56
>> +++ doc-view.el 13 Mar 2008 18:11:37 -0000 1.57
>> @@ -600,7 +600,8 @@
>>
>> (defun doc-view-doc->txt (txt callback)
>> "Convert the current document to text and call CALLBACK when done."
>> - (make-directory (doc-view-current-cache-dir))
>> + (unless (file-exists-p (doc-view-current-cache-dir))
>> + (make-directory (doc-view-current-cache-dir)))
>
> Wouldn't using non-nil `parents' be a more simple solution?
>
> (make-directory (doc-view-current-cache-dir) t)
Indeed. I'll change that tomorrow if nobody does it till then.
Bye,
Tassilo
--
"Emacs is not a development tool but a way of life."
- David Kastrup in alt.religion.emacs -
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: doc-view.el: make-directory
2008-03-14 13:23 ` doc-view.el: make-directory Tassilo Horn
@ 2008-03-16 9:25 ` Tassilo Horn
0 siblings, 0 replies; 3+ messages in thread
From: Tassilo Horn @ 2008-03-16 9:25 UTC (permalink / raw)
To: emacs-devel
Tassilo Horn <tassilo@member.fsf.org> writes:
>>> --- doc-view.el 12 Mar 2008 15:26:48 -0000 1.56
>>> +++ doc-view.el 13 Mar 2008 18:11:37 -0000 1.57
>>> @@ -600,7 +600,8 @@
>>>
>>> (defun doc-view-doc->txt (txt callback)
>>> "Convert the current document to text and call CALLBACK when done."
>>> - (make-directory (doc-view-current-cache-dir))
>>> + (unless (file-exists-p (doc-view-current-cache-dir))
>>> + (make-directory (doc-view-current-cache-dir)))
>>
>> Wouldn't using non-nil `parents' be a more simple solution?
>>
>> (make-directory (doc-view-current-cache-dir) t)
>
> Indeed. I'll change that tomorrow if nobody does it till then.
Done!
Bye,
Tassilo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-16 9:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1JZrtx-0003NZ-Sa@cvs.savannah.gnu.org>
2008-03-13 22:24 ` doc-view.el: make-directory (was: Changes to emacs/lisp/doc-view.el, v) Reiner Steib
2008-03-14 13:23 ` doc-view.el: make-directory Tassilo Horn
2008-03-16 9:25 ` Tassilo Horn
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).