unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Meyering <jim@meyering.net>
To: Emacs development discussions <emacs-devel@gnu.org>
Subject: build from source fails on fedora-12 (with gcc 4.4.2)
Date: Fri, 23 Oct 2009 08:51:18 +0200	[thread overview]
Message-ID: <87vdi61u3d.fsf@meyering.net> (raw)

Here's the patch:

FYI, at first I thought it was a bug in gcc and reported it,
but Jakub Jelinek explained that it is a feature, and
suggested the work-around of using -P.

From 8e02dcac08aec4aa87a5130bcde547c955840dcd Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Fri, 23 Oct 2009 08:47:52 +0200
Subject: [PATCH] invoke $CPP with its -P option, to accommodate change in latest gcc

* configure.in: Use $CPP's -P option when creating Makefile and
src/Makefile.  This is required with at least by gcc 4.4.2, which
is part of fedora 12.  Otherwise, each backslash-newline pair in
the input would be mistakenly converted to a bare newline, yielding
invalid Makefiles.
* configure: Regenerate.
---
 ChangeLog    |   10 ++++++++++
 configure    |    6 ++----
 configure.in |    4 ++--
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ce05b51..7927e78 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2009-10-23  Jim Meyering  <meyering@redhat.com>
+
+	invoke $CPP with its -P option, to accommodate change in latest gcc
+	* configure.in: Use $CPP's -P option when creating Makefile and
+	src/Makefile.  This is required with at least by gcc 4.4.2, which
+	is part of fedora 12.  Otherwise, each backslash-newline pair in
+	the input would be mistakenly converted to a bare newline, yielding
+	invalid Makefiles.
+	* configure: Regenerate.
+
 2009-10-19  Dan Nicolaescu  <dann@ics.uci.edu>

 	* configure.in (vax-dec-vms): Remove, not supported anymore.
diff --git a/configure b/configure
index ee6871b..a4453af 100755
--- a/configure
+++ b/configure
@@ -26762,7 +26762,7 @@ echo creating lib-src/Makefile
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
       < Makefile.c > junk.c
-  $CPP $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
+  $CPP -P $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c
   cat junk1.c junk2.c > Makefile.new
   rm -f junk.c junk1.c junk2.c
@@ -26778,7 +26778,7 @@ echo creating src/Makefile
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
       < Makefile.c > junk.c
-  $CPP $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
+  $CPP -P $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c
   cat junk1.c junk2.c > Makefile.new
   rm -f junk.c junk1.c junk2.c
@@ -26832,5 +26832,3 @@ if test -n "$ac_unrecognized_opts" && test "$enable_option_checking" != no; then
   { $as_echo "$as_me:$LINENO: WARNING: Unrecognized options: $ac_unrecognized_opts" >&5
 $as_echo "$as_me: WARNING: Unrecognized options: $ac_unrecognized_opts" >&2;}
 fi
-
-
diff --git a/configure.in b/configure.in
index 87c820f..a110407 100644
--- a/configure.in
+++ b/configure.in
@@ -3057,7 +3057,7 @@ echo creating lib-src/Makefile
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
       < Makefile.c > junk.c
-  $CPP $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
+  $CPP -P $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c
   cat junk1.c junk2.c > Makefile.new
   rm -f junk.c junk1.c junk2.c
@@ -3073,7 +3073,7 @@ echo creating src/Makefile
   sed -e '1,/start of cpp stuff/d'\
       -e 's,/\*\*/#\(.*\)$,/* \1 */,' \
       < Makefile.c > junk.c
-  $CPP $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
+  $CPP -P $cpp_undefs -I. -I$srcdir/src $CPPFLAGS junk.c | \
       sed -e 's/^ /	/' -e '/^#/d' -e '/^[ 	\f]*$/d' > junk2.c
   cat junk1.c junk2.c > Makefile.new
   rm -f junk.c junk1.c junk2.c
--
1.6.5.1.305.g914c1




             reply	other threads:[~2009-10-23  6:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23  6:51 Jim Meyering [this message]
2009-10-23 15:01 ` build from source fails on fedora-12 (with gcc 4.4.2) Chong Yidong
2009-10-23 15:21   ` Jim Meyering
2009-10-23 16:19     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdi61u3d.fsf@meyering.net \
    --to=jim@meyering.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).