unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org, rms@gnu.org, deniz.a.m.dogan@gmail.com
Subject: Re: delete-file default to buffer-file-name if non-nil
Date: Mon, 17 May 2010 02:09:31 +0300	[thread overview]
Message-ID: <87vdan5stg.fsf@mail.jurta.org> (raw)
In-Reply-To: <F2AFA0DE3D114EC9977A8B9809BD3CCE@us.oracle.com> (Drew Adams's message of "Sun, 16 May 2010 13:20:56 -0700")

>>     M-x delete-file RET does attempt to delete the current buffer's
>>     file or its directory if it has no file.  Personally, I find this
>>     default sort of dangerous, although at least C-x C-w often
>>     fixes it.
>>
>> It seems dangerous to me too.
>
> But it seems the most appropriate default value, in terms of what one might want
> to delete. Don't you think so?

I think `read-file-name' should not use the default value when it is
not visible either in the prompt (displayed with the standard text
" (default filename): ") or in the minibuffer.

> If it is also dangerous, then some reasonable way should be found to deal
> with the danger - as opposed to simply changing the default value.
>
> Two (alternative) solutions that come to mind:
>
> 1. Insert the default value in the minibuffer. This assumes that the
> greatest danger is hitting RET without seeing what the file to be
> deleted is.

The argument INITIAL-CONTENTS is obsolete and should not be used.
It's possible to insert the default value to the minibuffer with `M-n'.

> 2. Require confirmation if RET is hit with no file name in the minibuffer.

Deleting from Dired requires confirmation, so perhaps `delete-file'
should require confirmation too.

-- 
Juri Linkov
http://www.jurta.org/emacs/



  reply	other threads:[~2010-05-16 23:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-15 18:05 delete-file default to buffer-file-name if non-nil Deniz Dogan
2010-05-15 18:30 ` Davis Herring
2010-05-15 22:10   ` Deniz Dogan
2010-05-16 20:04   ` Richard Stallman
2010-05-16 20:20     ` Drew Adams
2010-05-16 23:09       ` Juri Linkov [this message]
2010-05-17  0:28         ` Drew Adams
2010-05-17 13:51           ` Stefan Monnier
2010-05-17 14:56             ` Drew Adams
2010-05-17 16:15               ` Deniz Dogan
2010-05-17 23:09               ` Juri Linkov
2010-05-18 22:38                 ` Juri Linkov
2010-05-17 14:40       ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vdan5stg.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=deniz.a.m.dogan@gmail.com \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).