From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.devel Subject: bookmark from gnus article wrong modification Date: Fri, 16 Jul 2010 15:16:38 +0200 Organization: ThierryVolpiatto Message-ID: <87vd8ftvm1.fsf@tux.homenetwork> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279286395 31507 80.91.229.12 (16 Jul 2010 13:19:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 16 Jul 2010 13:19:55 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 16 15:19:49 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZkpR-0000oV-H1 for ged-emacs-devel@m.gmane.org; Fri, 16 Jul 2010 15:19:49 +0200 Original-Received: from localhost ([127.0.0.1]:58167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZkpQ-0005NC-Qo for ged-emacs-devel@m.gmane.org; Fri, 16 Jul 2010 09:19:48 -0400 Original-Received: from [140.186.70.92] (port=33453 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZkpL-0005N0-8s for emacs-devel@gnu.org; Fri, 16 Jul 2010 09:19:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZkpK-0003MN-3r for emacs-devel@gnu.org; Fri, 16 Jul 2010 09:19:43 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:42232) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZkpJ-0003M8-Uk for emacs-devel@gnu.org; Fri, 16 Jul 2010 09:19:42 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OZkpE-0000hO-4K for emacs-devel@gnu.org; Fri, 16 Jul 2010 15:19:36 +0200 Original-Received: from 27.77.197-77.rev.gaoland.net ([77.197.77.27]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Jul 2010 15:19:36 +0200 Original-Received: from thierry.volpiatto by 27.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 16 Jul 2010 15:19:36 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 35 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 27.77.197-77.rev.gaoland.net User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:81Inhk1V6UxCXAvOVuzs0L0xPaw= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127432 Archived-At: Hi, the last modification for compatibility with older emacs in gnus-sum.el is wrong. You should use the value of pos what is set to point IN THE ARTICLE BUFFER. If you use just (point) it will record the value of point in the summary buffer what is wrong and not what we want: ,---- | `(,subject | ,@(condition-case nil | (bookmark-make-record-default 'no-file 'no-context (point)) | (wrong-number-of-arguments | (bookmark-make-record-default 'point-only))) `---- See precedent patchs for example. Also this change add tabs that also is wrong i think (you should untabify). This changes occur in: ,---- | changeset: 109420:8fa1cd12c77f | user: Katsumi Yamaoka | date: Thu Jul 15 00:54:06 2010 +0000 | summary: Make gnus-summary-bookmark-make-record work for Emacs 23 as well. `---- -- Thierry Volpiatto Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997