From: Michael Albinus <michael.albinus@gmx.de>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: patch-copy-dir-with-stefan-changes
Date: Thu, 10 Feb 2011 09:38:47 +0100 [thread overview]
Message-ID: <87vd0s8eso.fsf@gmx.de> (raw)
In-Reply-To: <871v3hgkid.fsf@gmail.com> (Thierry Volpiatto's message of "Wed, 09 Feb 2011 18:55:54 +0100")
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> here another approach to fix copy-directory and dired.
>>
>> Looks good.
>>
>> I'm not sure how it can get away with removing dired-do-create-files
>> without removing any call to it,
> OOPS! Of course we need it! It wouldn't work without it.
> I remove it in the patch by error, sorry.
For what I can tell, this patch looks pretty good. I've tested all three
scenarios Thierry has explained in a previous mail, and I've tested it
with local directories as well as with Tramp's ssh and rsync
methods. All results are as expected.
I vote for installing the patch into the emacs-23 branch.
Best regards, Michael.
next prev parent reply other threads:[~2011-02-10 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mxm7wnk2.fsf@gmail.com>
[not found] ` <jwv7hdbtdip.fsf-monnier+emacs@gnu.org>
[not found] ` <87mxm7c9ut.fsf@gmail.com>
[not found] ` <jwvmxm6z56k.fsf-monnier+emacs@gnu.org>
[not found] ` <87r5bh2sf8.fsf@gmail.com>
2011-02-09 16:42 ` patch-copy-dir-with-stefan-changes Stefan Monnier
2011-02-09 17:55 ` patch-copy-dir-with-stefan-changes Thierry Volpiatto
2011-02-10 8:38 ` Michael Albinus [this message]
2011-02-10 15:49 ` patch-copy-dir-with-stefan-changes Chong Yidong
2011-02-10 16:18 ` patch-copy-dir-with-stefan-changes Michael Albinus
2011-02-11 23:47 ` patch-copy-dir-with-stefan-changes Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd0s8eso.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=thierry.volpiatto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).