From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH updated] Support for filesystem watching (inotify) Date: Fri, 24 Jun 2011 07:18:44 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87vcvvv2vv.fsf@lifelogs.com> References: <201106040034.15598.ruediger@c-plusplus.de> <201106061825.25078.ruediger@c-plusplus.de> <201106240250.01247.ruediger@c-plusplus.de> <87hb7fh6qf.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1308922642 15777 80.91.229.12 (24 Jun 2011 13:37:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2011 13:37:22 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 24 15:37:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qa6ZS-0000YO-W9 for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2011 15:37:19 +0200 Original-Received: from localhost ([::1]:60882 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa6ZR-0007Mn-MV for ged-emacs-devel@m.gmane.org; Fri, 24 Jun 2011 09:37:17 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:49705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa5Le-0003Lz-Aj for emacs-devel@gnu.org; Fri, 24 Jun 2011 08:18:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qa5Lc-00036Z-OP for emacs-devel@gnu.org; Fri, 24 Jun 2011 08:18:58 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:51488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qa5Lc-00036R-8l for emacs-devel@gnu.org; Fri, 24 Jun 2011 08:18:56 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qa5Lb-0006lW-LL for emacs-devel@gnu.org; Fri, 24 Jun 2011 14:18:55 +0200 Original-Received: from 38.98.147.133 ([38.98.147.133]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2011 14:18:55 +0200 Original-Received: from tzz by 38.98.147.133 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 24 Jun 2011 14:18:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 21 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.133 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:S23lcNUvUQNyT9SEI4IEnLHvCP0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 80.91.229.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140941 Archived-At: On Fri, 24 Jun 2011 05:19:20 -0500 Ted Zlatanov wrote: TZ> You have several symbols like Qmodify, and I wanted to suggest that you TZ> could use a name prefix like for example gnutls.c: TZ> and that you assign a numeric value directly to the symbol when it's TZ> initialized instead of statically doing case statements in your TZ> code. I noticed you were using the DEFSYM macro, I didn't know about it. I put it into gnutls.c. #+begin_src c DEFSYM(Qgnutls_e_interrupted, "gnutls-e-interrupted"); Fput (Qgnutls_e_interrupted, Qgnutls_code, make_number (GNUTLS_E_INTERRUPTED)); #+end_src ...and I wanted to mention how I put a numeric value in the symbol's property list instead of setting it as the value. HTH. Ted