From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Romain Francoise <romain@orebokech.com>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH v2] POSIX ACL support
Date: Thu, 06 Dec 2012 20:48:43 +0100
Organization: orebokech dot com
Message-ID: <87vccfm06c.fsf@silenus.orebokech.com>
References: <87zk1wxlto.fsf@silenus.orebokech.com>
	<w2vcch1bd7.fsf@fencepost.gnu.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: ger.gmane.org 1354823334 20783 80.91.229.3 (6 Dec 2012 19:48:54 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 6 Dec 2012 19:48:54 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Glenn Morris <rgm@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 06 20:49:07 2012
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1TghRR-0004pt-3k
	for ged-emacs-devel@m.gmane.org; Thu, 06 Dec 2012 20:49:05 +0100
Original-Received: from localhost ([::1]:32935 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1TghRE-0008Bg-Kr
	for ged-emacs-devel@m.gmane.org; Thu, 06 Dec 2012 14:48:52 -0500
Original-Received: from eggs.gnu.org ([208.118.235.92]:60696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <romain@orebokech.com>) id 1TghRB-0008BC-Ca
	for emacs-devel@gnu.org; Thu, 06 Dec 2012 14:48:50 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <romain@orebokech.com>) id 1TghR9-0007N3-5l
	for emacs-devel@gnu.org; Thu, 06 Dec 2012 14:48:49 -0500
Original-Received: from stringer.orebokech.com ([88.190.240.207]:41286)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <romain@orebokech.com>)
	id 1TghR9-0007Mx-0b; Thu, 06 Dec 2012 14:48:47 -0500
Original-Received: from silenus.orebokech.com (silenus [192.168.1.4])
	by stringer.orebokech.com (Postfix) with ESMTP id 6A7C2188001E;
	Thu,  6 Dec 2012 20:48:43 +0100 (CET)
Original-Received: by silenus.orebokech.com (Postfix, from userid 1000)
	id 4140EA0852; Thu,  6 Dec 2012 20:48:43 +0100 (CET)
In-Reply-To: <w2vcch1bd7.fsf@fencepost.gnu.org> (Glenn Morris's message of
	"Tue, 04 Dec 2012 21:28:04 -0500")
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 88.190.240.207
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:155322
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/155322>

Hi Glenn,

Glenn Morris <rgm@gnu.org> writes:

>> +The return value is a string containing the textual representation of
>> +the ACL entries.

> Maybe give an example?

Ok.

> Apart from those trivial comments, just needs a NEWS entry.
> Otherwise looks good to me...

Thanks for the review!

I'll add the NEWS and ChangeLog entries and then I can install it myself
to the trunk, but I think I need to get the go-ahead from Stefan and/or
Chong?