unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* RFE: require and load-path-shadowing
@ 2013-01-10 21:07 Achim Gratz
  2013-01-10 23:43 ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Achim Gratz @ 2013-01-10 21:07 UTC (permalink / raw)
  To: emacs-devel


There is currently a problem with package manager when a package is
installed from a package archive,that package is already installed
either in Emacs core or site-lisp, and when (parts of) said package have
already been loaded when ELPA tries to install: the byte-compiler will
use the already loaded definitions rather than the new ones from the
package to install.

Since this would seem a more general problem, I suggest that in a
situation similar to this:

(feature-file 'org-macs)
=> "/usr/local/share/emacs/site-lisp/org/org-macs.elc"
(find-library-name "org-macs")
=> "/home/lisp/org-mode/lisp/org-macs.el"

a subsequent (require 'org-macs) should not simply return "t", but
actually load the required feature again from the current load-path, at
least as an option (when require-reload-shadowed-feature bound to true
or something like that).  A workaround in package manager would need to
check and modify the features variable, which doesn't seem the right
thing to do.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: RFE: require and load-path-shadowing
  2013-01-10 21:07 RFE: require and load-path-shadowing Achim Gratz
@ 2013-01-10 23:43 ` Glenn Morris
  2013-01-11  8:21   ` Achim Gratz
  2013-01-20  7:38   ` Achim Gratz
  0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2013-01-10 23:43 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-devel

Achim Gratz wrote:

> There is currently a problem with package manager when a package is
> installed from a package archive,that package is already installed
> either in Emacs core or site-lisp, and when (parts of) said package have
> already been loaded when ELPA tries to install: the byte-compiler will
> use the already loaded definitions rather than the new ones from the
> package to install.

I guess this would be

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: RFE: require and load-path-shadowing
  2013-01-10 23:43 ` Glenn Morris
@ 2013-01-11  8:21   ` Achim Gratz
  2013-01-20  7:38   ` Achim Gratz
  1 sibling, 0 replies; 6+ messages in thread
From: Achim Gratz @ 2013-01-11  8:21 UTC (permalink / raw)
  To: emacs-devel

Glenn Morris <rgm <at> gnu.org> writes:
> I guess this would be
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125

Almost, but not quite.  The issue described there would be solved with this
enhancement, yes.

I'll respond to that bug report later (I must have missed it earlier), but the
assumption that the Makefile compiles the files in different order than the
package manager is not true.  But the Makefile carefully avoids loading anything
before starting the compilation and of course that load-path is correctly set up
from the very beginning (something package manager simply can't do, short of
starting a new Emacs process).  It would still fail if anything it needed to
re-evaluated was already present with 'emacs -batch -Q' (say already dumped),
however - which is why I think this should be solved in a more general fashion.


Regards,
Achim.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: RFE: require and load-path-shadowing
  2013-01-10 23:43 ` Glenn Morris
  2013-01-11  8:21   ` Achim Gratz
@ 2013-01-20  7:38   ` Achim Gratz
  2013-01-20 20:17     ` Glenn Morris
  1 sibling, 1 reply; 6+ messages in thread
From: Achim Gratz @ 2013-01-20  7:38 UTC (permalink / raw)
  To: emacs-devel

Glenn Morris writes:
> I guess this would be
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125

I've posted a possible patch there, could it please be reviewed?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: RFE: require and load-path-shadowing
  2013-01-20  7:38   ` Achim Gratz
@ 2013-01-20 20:17     ` Glenn Morris
  2013-01-21  6:53       ` Achim Gratz
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2013-01-20 20:17 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-devel

Achim Gratz wrote:

> Glenn Morris writes:
>> I guess this would be
>>
>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125
>
> I've posted a possible patch there, could it please be reviewed?

I don't need to review it because it is functionally identical to one I
wrote last year. Stefan prefers to do something else

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125#59



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: RFE: require and load-path-shadowing
  2013-01-20 20:17     ` Glenn Morris
@ 2013-01-21  6:53       ` Achim Gratz
  0 siblings, 0 replies; 6+ messages in thread
From: Achim Gratz @ 2013-01-21  6:53 UTC (permalink / raw)
  To: emacs-devel

Glenn Morris writes:
>> I've posted a possible patch there, could it please be reviewed?
>
> I don't need to review it because it is functionally identical to one I
> wrote last year.

Yes, I wrote this in the description.  I wasn't talking about reviewing
the principle, but the suggested implementation.

> Stefan prefers to do something else
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10125#59

Maybe I'm not reading it correctly, but I don't see why his preference
for option #2 (which implicitly won't happen until perhaps Emacs 25 and
requires further discussion) should preclude implementing option #1 as a
stopgap measure until #2 is ready to replace it with.  Unless of course
there's something obviously or non-obviously wrong with that
implementation.

Package manager is a tool for users who don't know or don't want to know
about the behind-the-scenes things in Emacs.  This bug is a trap for the
unwary and it can break Emacs for them very obtusely.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-01-21  6:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-10 21:07 RFE: require and load-path-shadowing Achim Gratz
2013-01-10 23:43 ` Glenn Morris
2013-01-11  8:21   ` Achim Gratz
2013-01-20  7:38   ` Achim Gratz
2013-01-20 20:17     ` Glenn Morris
2013-01-21  6:53       ` Achim Gratz

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).