From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Sat, 01 Jun 2013 23:39:12 +0400 Message-ID: <87vc5x1uzj.fsf@yandex.ru> References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1370116300 27339 80.91.229.3 (1 Jun 2013 19:51:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Jun 2013 19:51:40 +0000 (UTC) Cc: Stefan Monnier , Emacs development discussions To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 01 21:51:40 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uirpw-0001ub-GO for ged-emacs-devel@m.gmane.org; Sat, 01 Jun 2013 21:51:36 +0200 Original-Received: from localhost ([::1]:38562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uirpw-0005i1-76 for ged-emacs-devel@m.gmane.org; Sat, 01 Jun 2013 15:51:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uirpp-0005hY-HI for emacs-devel@gnu.org; Sat, 01 Jun 2013 15:51:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uirpk-0007hJ-6u for emacs-devel@gnu.org; Sat, 01 Jun 2013 15:51:29 -0400 Original-Received: from mail-la0-x22c.google.com ([2a00:1450:4010:c03::22c]:39576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uire2-0003eI-MZ for emacs-devel@gnu.org; Sat, 01 Jun 2013 15:39:18 -0400 Original-Received: by mail-la0-f44.google.com with SMTP id er20so233722lab.3 for ; Sat, 01 Jun 2013 12:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:x-antivirus:x-antivirus-status; bh=Y0p+gbAorctkNWnjA9ELsq8pK5NA64lrMm/sFeptMPk=; b=E/mljI6uoPLWMP6C3bdEUp4N+vdnifqwBJRddIQQu4I0AOnOwEv5odAuCcs4k1mtIE ffY9ScBCs/rc3ITpCK5mYJVnfI2BmfHw8wk+w1A1kmmpd0PgODxvU3Y9/JN0Q6fvjYi1 bnjz6eMfRxEpa/FaYc3ECf82ia5HVftN7mrBmd3emlwkumS5CEOM8Okl58mqtj/rYAGD gE6+xO3PNm3wlXAaMYN57Ak6Ycgud4RujarjTxjiWNfMFb00FiF5R9+E3ROD/CAKMNEl k1crntcu7vPG8p4Efclt4Mq7ZKgOJ0VPAXU2x3nnVEsy0K9Cg7u2s/JFrA+lbiafrY2M sORg== X-Received: by 10.112.150.42 with SMTP id uf10mr8107218lbb.89.1370115557200; Sat, 01 Jun 2013 12:39:17 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPSA id uo8sm18972067lbb.5.2013.06.01.12.39.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 01 Jun 2013 12:39:16 -0700 (PDT) In-Reply-To: (Daniel Hackney's message of "Wed, 24 Apr 2013 22:52:03 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130601-0, 01.06.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159971 Archived-At: Hi Daniel, Any news on this? I've been holding off on Bug#13291 both because it would complicate the rebase of this changeset, and also because I'd like to use the test harness you have here. Daniel Hackney writes: >>> I've been looking at the patch, trying to understand what it does, and >>> I think I'd first really need to see a good description of what it does, >>> because obviously it doesn't just switch to using a defstruct. It also >>> does things like renaming functions and various minor refactorings that >>> don't seem directly related (they don't necessarily seem bad either, >>> but I wasn't able to understand all of what's going on from just >>> looking at the patch). > > I'll do a better job of explaining the whole patch. Should I include > that in some sort of file in the repo or just on the mailing list? > Would a detailed-ish explanation of the changes and rationale be > appropriate for the ChangeLog or NEWS files? You can start with ChangeLog files. When writing a changelog entry, one usually briefly describes and sometimes justifies the mechanical transformations being performed on the code, and it helps other people understand the changes. I'd hold off on writing a separate extensive description until receiving follow-up questions. I see you've also already started on NEWS entries. > About package-x.el, is the HTML and RSS updating functionality actually > used? Currently, the only way to access the functionality is calling > `package-maint-add-news-item' or the non-interactive > `package-upload-buffer-internal' directly. GNU ELPA clearly doesn't use > the version in package-x.el, as the HTML generated is not what > package-x produces. Probably not. Melpa and Elpakit don't seem to be using it either. > Can I consider it unused and delete it? If not, I'll refactor it with > the rest of the code. Personally, I'd delete them, but that's not my call. Maybe decorate them with FIXMEs, leave them unfixed and see if anyone complains up until the pretest?