unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] support a few of the new features of C++11 in syntax highlighting
Date: Tue, 18 Nov 2014 19:33:03 +0100	[thread overview]
Message-ID: <87vbmc4aw0.fsf@wanadoo.es> (raw)
In-Reply-To: 546B8BED.9050208@dancol.org

Daniel Colascione <dancol@dancol.org> writes:

> Patch cc-engine to recognize the proper context if you care so much.
> Until you can do that, do not touch cc-mode.

Have you become the maintainer of c-mode overnight whithout anybody
noticing? No? Then, please abstain from commanding people about what
they can and cannot touch.

(BTW, I would never introduce a change on c-mode, Emacs or any project
in general without the maintainer(s) approval, if such change has the
most remote possibility of being controversial or risky.)

>>> They're not like "const" at all.
>> 
>> As far as c-mode is concerned, they are like "certain variety of const."
>
> No, lexically, they are completely different. You cannot have a
> variable called "const". You can have a variable called "final".

Yes, you made that clear on your previous message. But where the
"override/final" *specifiers* are expected, "const" is also legal. If
you mean that c-mode fontifies "const" on first sight because it makes
no distinctions between the multiple roles of "const", that's ok, then
we have no existing heuristics for detecting "override/final".

>> If c-mode uses the same heuristics everywhere for fontifying `const',
>> that means that we cannot exploit the existing mechanism for fontifying
>> "override" and "final". To bad. Then I would vote for adding them to
>> some list of keywords. As I said, not having them fontified when they
>> should is worse than having them fontified when they shouldn't.
>
> Do not introduce bugs into Emacs cc-mode. It's one of Emacs most
> widely used features and will not change to suit your non-universal
> preferences. If you want to err on the side of over-highlighting, you
> are free to create a derived mode locally.

<g>

> Do it right or not at all. 

C-mode is not doing right wrt "override/final". My *opinion* is that my
wrong is less wrong than your wrong.




  reply	other threads:[~2014-11-18 18:33 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 12:51 [PATCH] support a few of the new features of C++11 in syntax highlighting Paul Pogonyshev
2014-01-25 19:58 ` Glenn Morris
2014-01-25 21:56   ` Stefan Monnier
2014-01-25 22:34     ` Daniel Colascione
2014-01-26  0:27       ` Glenn Morris
2014-01-26 12:29         ` Daniel Colascione
2014-01-26 15:21       ` Alan Mackenzie
2014-05-11  6:48 ` Václav Zeman
2014-05-11 16:00   ` Óscar Fuentes
2014-05-11 18:21     ` Glenn Morris
2014-05-11 20:19       ` Óscar Fuentes
2014-05-11 22:09         ` Alan Mackenzie
2014-05-11 22:38           ` Óscar Fuentes
2014-05-14 20:13             ` Alan Mackenzie
2014-05-14 21:20               ` Óscar Fuentes
2014-05-15  1:52               ` Stefan Monnier
2014-05-16 16:07                 ` Alan Mackenzie
2014-05-16 17:59                   ` Eli Zaretskii
2014-05-17  8:31                     ` Alan Mackenzie
2014-05-17  9:24                       ` Eli Zaretskii
2014-05-17 12:39                         ` Michael Albinus
2014-05-17 14:14                           ` Stefan Monnier
2014-05-17 14:24                             ` Michael Albinus
2014-05-17 15:10                               ` Stefan Monnier
2014-05-17 13:27                         ` Óscar Fuentes
2014-05-17 14:06                           ` Eli Zaretskii
2014-05-16 23:42                   ` Stefan Monnier
2014-05-17  4:17                     ` Richard Stallman
2014-05-17  9:03                       ` Alan Mackenzie
2014-05-17 15:45                         ` Richard Stallman
2014-05-19 15:46                         ` Barry Warsaw
2014-05-17  8:42                     ` Alan Mackenzie
2014-05-17 14:09                       ` Stefan Monnier
2014-11-16 17:36           ` Rüdiger Sonderfeld
2014-11-16 18:07             ` Óscar Fuentes
2014-11-18  2:41               ` Rüdiger Sonderfeld
2014-11-18  3:30                 ` Óscar Fuentes
2014-11-18 12:48                   ` Daniel Colascione
2014-11-18 14:47                     ` Óscar Fuentes
2014-11-18 16:36                       ` Rüdiger Sonderfeld
2014-11-18 17:13                         ` Daniel Colascione
2014-11-18 18:01                           ` Óscar Fuentes
2014-11-18 18:11                             ` Daniel Colascione
2014-11-18 18:33                               ` Óscar Fuentes [this message]
2014-11-18 12:49                 ` Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbmc4aw0.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).