From: jca@wxcvbn.org (Jérémie Courrèges-Anglas)
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] gnutls: Add SNI support
Date: Mon, 24 Nov 2014 13:33:23 +0100 [thread overview]
Message-ID: <87vbm4ok18.fsf@joy.wxcvbn.org> (raw)
In-Reply-To: 87wq6k3i99.fsf@toke.dk
Toke Høiland-Jørgensen <toke@toke.dk> writes:
[...]
> Oh, and there's a bit of a hack in trying to detect whether the hostname
> is an IPv4 or IPv6 literal (in which case the hostname shouldn't be
> included in the handshake). Not sure if omitting that check entirely
> will work, or if there's a better way to detect this case.
Better not omit the check. The common trick is to use inet_pton(3) to
see if the param can be converted into an address. Now this raises
portability issues, which may be solved by the inet_pton gnulib
module[1].
[1] https://www.gnu.org/software/gnulib/manual/html_node/inet_005fpton.html
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
next prev parent reply other threads:[~2014-11-24 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 12:17 [PATCH] gnutls: Add SNI support Toke Høiland-Jørgensen
2014-11-24 12:28 ` Thien-Thi Nguyen
2014-11-24 13:08 ` Toke Høiland-Jørgensen
2014-11-24 14:50 ` Lars Magne Ingebrigtsen
2014-11-24 20:56 ` Florian Weimer
2014-11-24 12:33 ` Jérémie Courrèges-Anglas [this message]
2014-11-26 21:52 ` Lars Magne Ingebrigtsen
2014-11-26 22:12 ` Lars Magne Ingebrigtsen
2014-11-27 9:01 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbm4ok18.fsf@joy.wxcvbn.org \
--to=jca@wxcvbn.org \
--cc=emacs-devel@gnu.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).