From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Deal gracefully with up-events (Bug#19746) Date: Tue, 11 Aug 2015 07:01:49 +0200 Message-ID: <87vbcme7uq.fsf@fencepost.gnu.org> References: <1439215156-26672-1-git-send-email-dak@gnu.org> <1439215156-26672-2-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439269350 27390 80.91.229.3 (11 Aug 2015 05:02:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Aug 2015 05:02:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 11 07:02:29 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZP1hl-0002bN-6b for ged-emacs-devel@m.gmane.org; Tue, 11 Aug 2015 07:02:29 +0200 Original-Received: from localhost ([::1]:32841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP1hk-0007PT-FC for ged-emacs-devel@m.gmane.org; Tue, 11 Aug 2015 01:02:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP1hh-0007PJ-OH for emacs-devel@gnu.org; Tue, 11 Aug 2015 01:02:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZP1hg-0002KE-BM for emacs-devel@gnu.org; Tue, 11 Aug 2015 01:02:25 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZP1hg-0002Jw-7e; Tue, 11 Aug 2015 01:02:24 -0400 Original-Received: from localhost ([127.0.0.1]:49516 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1ZP1hf-0008GX-NI; Tue, 11 Aug 2015 01:02:24 -0400 Original-Received: by lola (Postfix, from userid 1000) id D8A5DDF384; Tue, 11 Aug 2015 07:01:49 +0200 (CEST) In-Reply-To: (Stefan Monnier's message of "Mon, 10 Aug 2015 17:58:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188716 Archived-At: Stefan Monnier writes: >> * keyboard.c (apply_modifiers_uncached, parse_solitary_modifier) >> (parse_modifiers_uncached): React gracefully to "up-" modifiers: >> those may easily be injected by user-level Lisp code. >> (read_key_sequence): Discard unbound up-events like unbound >> down-events: they are even more likely only relevant for special >> purposes. > > Looks good. > >> While Emacs will not produce up-events on its own currently (those are >> converted to drag or click events before being converted to >> Lisp-readable structures), the input queue can be made to contain them >> by synthesizing events to `unread-command-events'. Emacs should deal >> consistently with such events. > > This probably belongs in a comment rather than in the ChangeLog. Well, the information is in there, just written differently. And "on its own currently" is correct in the commit message but might become wrong in a comment eventually. -- David Kastrup