From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 8726de6: Finish excising electric indent from `open-line' Date: Sun, 22 Nov 2015 15:59:02 +0100 Message-ID: <87vb8u84i1.fsf@fencepost.gnu.org> References: <20151122045054.17266.64677@vcs.savannah.gnu.org> <87io4u362x.fsf@red-bean.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448204350 9939 80.91.229.3 (22 Nov 2015 14:59:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Nov 2015 14:59:10 +0000 (UTC) Cc: Karl Fogel , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 22 15:59:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a0W6d-0005kZ-Rv for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 15:59:07 +0100 Original-Received: from localhost ([::1]:56376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0W6e-0001cs-2p for ged-emacs-devel@m.gmane.org; Sun, 22 Nov 2015 09:59:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0W6a-0001ci-CW for emacs-devel@gnu.org; Sun, 22 Nov 2015 09:59:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a0W6Z-0008EF-Fo for emacs-devel@gnu.org; Sun, 22 Nov 2015 09:59:04 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a0W6Z-0008EB-CM; Sun, 22 Nov 2015 09:59:03 -0500 Original-Received: from localhost ([127.0.0.1]:57516 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.82) (envelope-from ) id 1a0W6Y-0001mF-NL; Sun, 22 Nov 2015 09:59:02 -0500 Original-Received: by lola (Postfix, from userid 1000) id 3AC8CDF5F8; Sun, 22 Nov 2015 15:59:02 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Sun, 22 Nov 2015 09:51:24 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195021 Archived-At: Stefan Monnier writes: >> Oh, well. Although mostly pleased with Emacs' transition to >> distributed version control, I do miss one thing: being able to edit >> log messages after the fact! > > Yes, that's a shortcoming of Git. Hopefully it'll be fixed eventually. It is a limitation, not a shortcoming. The commit message is intentionally part of the commit id and consequently part of the commit graph. You can rewrite messages when rebasing, but the result is a new commit graph. This ensures the integrity of the commit tree including the original commit messages. Consequently it will not "be fixed", ever. It's part of the system design. For the purpose of automated ChangeLog generation/maintenance, one could add additional information to commits (possibly including a commit message for the sake of ChangeLog generation) with "git notes" and integrate it at ChangeLog generation time. But the canonical commit message itself is off-limits once the commit is part of an accepted commit tree. -- David Kastrup