unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Karl Fogel <kfogel@red-bean.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 8726de6: Finish excising electric indent from `open-line'
Date: Sun, 22 Nov 2015 15:59:02 +0100	[thread overview]
Message-ID: <87vb8u84i1.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvd1v2hyul.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Sun, 22 Nov 2015 09:51:24 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> Oh, well.  Although mostly pleased with Emacs' transition to
>> distributed version control, I do miss one thing: being able to edit
>> log messages after the fact!
>
> Yes, that's a shortcoming of Git.  Hopefully it'll be fixed eventually.

It is a limitation, not a shortcoming.  The commit message is
intentionally part of the commit id and consequently part of the commit
graph.  You can rewrite messages when rebasing, but the result is a new
commit graph.  This ensures the integrity of the commit tree including
the original commit messages.

Consequently it will not "be fixed", ever.  It's part of the system
design.  For the purpose of automated ChangeLog generation/maintenance,
one could add additional information to commits (possibly including a
commit message for the sake of ChangeLog generation) with "git notes"
and integrate it at ChangeLog generation time.

But the canonical commit message itself is off-limits once the commit is
part of an accepted commit tree.

-- 
David Kastrup



  reply	other threads:[~2015-11-22 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151122045054.17266.64677@vcs.savannah.gnu.org>
     [not found] ` <E1a0Mc2-0004VA-3j@vcs.savannah.gnu.org>
2015-11-22  5:25   ` [Emacs-diffs] emacs-25 8726de6: Finish excising electric indent from `open-line' Stefan Monnier
2015-11-22  6:23     ` Karl Fogel
2015-11-22 14:51       ` Stefan Monnier
2015-11-22 14:59         ` David Kastrup [this message]
2015-11-22 16:24           ` Stefan Monnier
2015-11-22 15:59       ` Yuri Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb8u84i1.fsf@fencepost.gnu.org \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).