From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Vitalie Spinu Newsgroups: gmane.emacs.devel Subject: Re: [Patch] hard-widen-limits [was Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]] Date: Sun, 24 Apr 2016 20:01:56 +0200 Message-ID: <87vb36dgx7.fsf@gmail.com> References: <20160311151512.GD2888@acm.fritz.box> <877fgusum3.fsf@gmail.com> <8737risu8d.fsf@gmail.com> <87mvpqqxy7.fsf@gmail.com> <877fguqp8x.fsf@gmail.com> <87bn65pgk2.fsf@gmail.com> <87y499nz79.fsf@gmail.com> <87zithez9b.fsf@gmail.com> <940ff677-80dc-848b-5626-23c7ac1591df@yandex.ru> <87k2jneaio.fsf@gmail.com> <87mvoj4gai.fsf@Rainer.invalid> <87a8kjdyvx.fsf@gmail.com> <87lh43dty8.fsf@linux-m68k.org> <874mardm1u.fsf@gmail.com> <87h9erdlnt.fsf@linux-m68k.org> <87zisjc63c.fsf@gmail.com> <87d1pfdkcc.fsf@linux-m68k.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461520942 30246 80.91.229.3 (24 Apr 2016 18:02:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 18:02:22 +0000 (UTC) Cc: Achim Gratz , emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 20:02:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auOMQ-0007kn-66 for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 20:02:22 +0200 Original-Received: from localhost ([::1]:56131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOMM-0006h3-C6 for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 14:02:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOM7-0006eL-9m for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:02:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auOM4-0006b7-42 for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:02:03 -0400 Original-Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:34908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auOM3-0006aJ-Tu for emacs-devel@gnu.org; Sun, 24 Apr 2016 14:02:00 -0400 Original-Received: by mail-wm0-x22a.google.com with SMTP id e201so64342537wme.0 for ; Sun, 24 Apr 2016 11:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=83jg2iUnbrsDNp4HTu/fqCp4Yjd1DmKOJum7kTAMYn4=; b=QdzjJpl7KvWhNg1Ty8I60+jp7hMvw8vopHRD8E51eM7BuOS+B35lmHuJ77mIoy94tM 5goYAFw+p2fgwlU82dbDDKUAA5Yifkx5ShbW4zqnRGXkkSE7tfr6Zpf4v11v+zzjNd+O 59/KiQdlzbA5wuPQOTGcJoxLCagtpgaNn2+WSNUfxdrptBF+ldzzmA1wYYzId703p88z ulwfxF85ygdkP3duUoeggQpBUa3sncyFwU8X81kAsYYsIRjdVcuwEQRN1vObmKTdJcoc DtYyfZp99AdrAfCToZENy/qHRjFE/Y/E2RlkLF1u2wXlcTHroGmiJ2pPgNVx0QnVHxyz LmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=83jg2iUnbrsDNp4HTu/fqCp4Yjd1DmKOJum7kTAMYn4=; b=TxmJ8C51HTyYvfnOv6oHEkjz3gfmMH/n1eMNesy0tCQ1EBB6gC28oa8WDXKOW8nfGv dkeFhVAYGgItmAI275cqnCDR1Ws2C6/TSlVHnsOF1CBjhp0jdqCfdjuAxmYYdAbrjVYa N38Q6HYbol88bIZ/YHC5b57h3iraOxd3yrFZhw2iH/KdKMDqlgPPjqiiNKOVLvpEwQxL XoPQ7IjnsH7QAwJwUPcG9ouAPiIVcicVL2ssfVy1yd+QSApjwGShMadBA7OhRTDQHC93 9cY11geIxhZpgMXspxaNgRH6fNFKhoXiUtUiF6+9qHrW7vryORXT6QcfblfflvfxpUDQ gEeg== X-Gm-Message-State: AOPr4FVD3DKSDnm1+lvNdIVgD52pzgUrY4Zpv8q9RYVrTrTMwLP8UrFwmJqVr0V+Eij2RA== X-Received: by 10.194.21.65 with SMTP id t1mr30766129wje.12.1461520918939; Sun, 24 Apr 2016 11:01:58 -0700 (PDT) Original-Received: from localhost ([143.176.214.220]) by smtp.gmail.com with ESMTPSA id u187sm3586468wmu.21.2016.04.24.11.01.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Apr 2016 11:01:57 -0700 (PDT) In-Reply-To: <87d1pfdkcc.fsf@linux-m68k.org> (Andreas Schwab's message of "Sun, 24 Apr 2016 18:48:03 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203270 Archived-At: >> On Sun, Apr 24 2016 18:48, Andreas Schwab wrote: > Vitalie Spinu writes: >>>> On Sun, Apr 24 2016 18:19, Andreas Schwab wrote: >> >>> Vitalie Spinu writes: >> >>>>>> On Sun, Apr 24 2016 15:20, Andreas Schwab wrote: >>>> >>>>> Vitalie Spinu writes: >>>> >>>>>> @@ -1692,7 +1692,7 @@ exec_byte_code (Lisp_Object bytestr, Lisp_Object vector, Lisp_Object maxdepth, >>>>>> >>>>>> CASE (Bwiden): >>>>>> BEFORE_POTENTIAL_GC (); >>>>>> - PUSH (Fwiden ()); >>>>>> + TOP = Fwiden (TOP); >>>> >>>>> You are clobbering the stack here. Instead of pushing a new value you >>>>> are overwriting an unrelated value on the stack. >>>> >>>> I don't think so. I pick an argument form the stack and put the return value in >>>> it. This is what all one-arg functions do in bytecode.c. >> >>> But nobody is pushing that argument. >> >> I am not pushing anything. > Exactly. This opcode takes no argument, and you cannot change that. Could you please elaborate a bit where you think the problem is? What exactly I cannot change? I am changing the number of argument of widen (from zero to one) and adjusting the byte code table. Do you say that's not the right way to do it? How should I do it then? Vitalie