Re: emacs-25 26d4da0: New input method "probhat" for Bengali

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Michael Albinus]

eliz@gnu.org (Eli Zaretskii) writes:

> +;; Probhat Input Method
> +(quail-define-package
> + "probhat" "Bengali-probhat" "probhat" t
> + "Porbhat for Bangla" nil t nil nil nil nil nil nil nil nil t)
     ^^^^^^^

Shouldn't this be "Probhat"?

Best regards, Michael.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Yes yes, in the last mail i mentioned about that typo and fixed layout name
also. :)
On Jun 27, 2016 1:53 AM, "Michael Albinus" <michael.albinus@gmx.de> wrote:

> eliz@gnu.org (Eli Zaretskii) writes:
>
> > +;; Probhat Input Method
> > +(quail-define-package
> > + "probhat" "Bengali-probhat" "probhat" t
> > + "Porbhat for Bangla" nil t nil nil nil nil nil nil nil nil t)
>      ^^^^^^^
>
> Shouldn't this be "Probhat"?
>
> Best regards, Michael.
>

[-- Attachment #2: Type: text/html, Size: 833 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

I think you are right.

On Sun, Jun 26, 2016, 3:53 PM Michael Albinus <michael.albinus@gmx.de>
wrote:

> eliz@gnu.org (Eli Zaretskii) writes:
>
> > +;; Probhat Input Method
> > +(quail-define-package
> > + "probhat" "Bengali-probhat" "probhat" t
> > + "Porbhat for Bangla" nil t nil nil nil nil nil nil nil nil t)
>      ^^^^^^^
>
> Shouldn't this be "Probhat"?
>
> Best regards, Michael.
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 905 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> Date: Mon, 27 Jun 2016 01:55:38 +0600
> From: উৎসব রায় <uroybd@gmail.com>
> Cc: emacs-devel@gnu.org
> 
> Yes yes, in the last mail i mentioned about that typo and fixed layout name also. :)

Please send a patch against what's in the repository.

Thanks.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

Replace this:

;; Probhat Input Method
(quail-define-package
"probhat" "Bengali-probhat" "probhat" t
"Porbhat for Bangla" nil t nil nil nil nil nil nil nil nil t)

with this please:

;; Probhat Input Method
(quail-define-package "Probhat" "Bengali" "bengali-probhat" t "Probhat for
Bangla" nil t nil nil nil nil nil nil nil nil t)

in the file "lisp/leim/quail/indian.el"

On Mon, Jun 27, 2016 at 8:42 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Mon, 27 Jun 2016 01:55:38 +0600
> > From: উৎসব রায় <uroybd@gmail.com>
> > Cc: emacs-devel@gnu.org
> >
> > Yes yes, in the last mail i mentioned about that typo and fixed layout
> name also. :)
>
> Please send a patch against what's in the repository.
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 3126 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Michael Albinus]

উৎসব রায় <uroybd@gmail.com> writes:

> Replace this:
>
> ;; Probhat Input Method
> (quail-define-package
> "probhat" "Bengali-probhat" "probhat" t
> "Porbhat for Bangla" nil t nil nil nil nil nil nil nil nil t)
>
> with this please:
>
> ;; Probhat Input Method
> (quail-define-package "Probhat" "Bengali" "bengali-probhat" t "Probhat
> for Bangla" nil t nil nil nil nil nil nil nil nil t)

Are you sure? All other uses in indian.el have a small letter case
package name, you take "Probhat". OTOH, all other uses take a title with
capitel letters, you take "bengali-probhat".

Best regards, Michael.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> Date: Mon, 27 Jun 2016 11:32:04 +0200
> 
> উৎসব রায় <uroybd@gmail.com> writes:
> 
> > ;; Probhat Input Method
> > (quail-define-package "Probhat" "Bengali" "bengali-probhat" t "Probhat
> > for Bangla" nil t nil nil nil nil nil nil nil nil t)
> 
> Are you sure? All other uses in indian.el have a small letter case
> package name, you take "Probhat". OTOH, all other uses take a title with
> capitel letters, you take "bengali-probhat".

More importantly, "bengali-probhat" is too long for an input method
indicator, it will take too much of the precious mode-line space.  It
should be 1 to 3 characters.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

In the Latest version I provided, (committed by Michael already) It will
show BngProbhat in mode line. I am not sure how to make it shorter. Should
we use simply "Probhat"? No other languages have any layout named probhat.
On Jun 27, 2016 9:47 PM, "Eli Zaretskii" <eliz@gnu.org> wrote:

> > From: Michael Albinus <michael.albinus@gmx.de>
> > Cc: Eli Zaretskii <eliz@gnu.org>,  emacs-devel@gnu.org
> > Date: Mon, 27 Jun 2016 11:32:04 +0200
> >
> > উৎসব রায় <uroybd@gmail.com> writes:
> >
> > > ;; Probhat Input Method
> > > (quail-define-package "Probhat" "Bengali" "bengali-probhat" t "Probhat
> > > for Bangla" nil t nil nil nil nil nil nil nil nil t)
> >
> > Are you sure? All other uses in indian.el have a small letter case
> > package name, you take "Probhat". OTOH, all other uses take a title with
> > capitel letters, you take "bengali-probhat".
>
> More importantly, "bengali-probhat" is too long for an input method
> indicator, it will take too much of the precious mode-line space.  It
> should be 1 to 3 characters.
>

[-- Attachment #2: Type: text/html, Size: 1717 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> Date: Mon, 27 Jun 2016 21:53:11 +0600
> From: উৎসব রায় <uroybd@gmail.com>
> Cc: emacs-devel@gnu.org, Michael Albinus <michael.albinus@gmx.de>
> 
> In the Latest version I provided, (committed by Michael already) It will show BngProbhat in mode line. I am not
> sure how to make it shorter. Should we use simply "Probhat"? No other languages have any layout named
> probhat.

How about BngPB instead?  All the other indicators in indian.el are at
most 5 characters, as in TmlIS and DevIT.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

Sounds ok. Use it then. :)
On Jun 27, 2016 10:26 PM, "Eli Zaretskii" <eliz@gnu.org> wrote:

> > Date: Mon, 27 Jun 2016 21:53:11 +0600
> > From: উৎসব রায় <uroybd@gmail.com>
> > Cc: emacs-devel@gnu.org, Michael Albinus <michael.albinus@gmx.de>
> >
> > In the Latest version I provided, (committed by Michael already) It will
> show BngProbhat in mode line. I am not
> > sure how to make it shorter. Should we use simply "Probhat"? No other
> languages have any layout named
> > probhat.
>
> How about BngPB instead?  All the other indicators in indian.el are at
> most 5 characters, as in TmlIS and DevIT.
>

[-- Attachment #2: Type: text/html, Size: 1049 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> Date: Tue, 28 Jun 2016 01:22:02 +0600
> From: উৎসব রায় <uroybd@gmail.com>
> Cc: emacs-devel@gnu.org, Michael Albinus <michael.albinus@gmx.de>
> 
> Sounds ok. Use it then. :)

Done.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Should I clone the repo and test if it works?

On Tue, Jun 28, 2016 at 1:40 AM, Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Tue, 28 Jun 2016 01:22:02 +0600
> > From: উৎসব রায় <uroybd@gmail.com>
> > Cc: emacs-devel@gnu.org, Michael Albinus <michael.albinus@gmx.de>
> >
> > Sounds ok. Use it then. :)
>
> Done.
>

[-- Attachment #2: Type: text/html, Size: 830 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Michael Albinus]

উৎসব রায় <uroybd@gmail.com> writes:

> Should I clone the repo and test if it works?

That's always a good idea.

Best regards, Michael.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

I've compiled and checked it today. Working like a charm! :)

On Tue, Jun 28, 2016 at 1:38 PM, Michael Albinus <michael.albinus@gmx.de>
wrote:

> উৎসব রায় <uroybd@gmail.com> writes:
>
> > Should I clone the repo and test if it works?
>
> That's always a good idea.
>
> Best regards, Michael.
>

[-- Attachment #2: Type: text/html, Size: 726 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[handa]

In article <83inwuy4y5.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:

> How about BngPB instead?  All the other indicators in indian.el are at
> most 5 characters, as in TmlIS and DevIT.

How about using some characteristic Bengali character + "PB"?
For instance, "কPB".

Perhaps that is a good idea for the other non-latin input methods.

---
K. Handa
handa@gnu.org

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[উৎসব রায়]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

"কPB" is actually a good idea! "ক" is the first letter of consonant section
of Bangla alphabet. It would be cool!
On Jun 29, 2016 8:10 PM, "handa" <handa@gnu.org> wrote:

> In article <83inwuy4y5.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
>
> > How about BngPB instead?  All the other indicators in indian.el are at
> > most 5 characters, as in TmlIS and DevIT.
>
> How about using some characteristic Bengali character + "PB"?
> For instance, "কPB".
>
> Perhaps that is a good idea for the other non-latin input methods.
>
> ---
> K. Handa
> handa@gnu.org
>

[-- Attachment #2: Type: text/html, Size: 1024 bytes --]

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> From: উৎসব রায় <uroybd@gmail.com>
> Date: Wed, 29 Jun 2016 15:07:14 +0600
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> I've compiled and checked it today. Working like a charm! :)

Thanks for testing.

Re: emacs-25 26d4da0: New input method "probhat" for Bengali

[Eli Zaretskii]

> From: handa <handa@gnu.org>
> Cc: uroybd@gmail.com, michael.albinus@gmx.de, emacs-devel@gnu.org
> Date: Wed, 29 Jun 2016 23:09:47 +0900
> 
> In article <83inwuy4y5.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
> 
> > How about BngPB instead?  All the other indicators in indian.el are at
> > most 5 characters, as in TmlIS and DevIT.
> 
> How about using some characteristic Bengali character + "PB"?
> For instance, "কPB".
> 
> Perhaps that is a good idea for the other non-latin input methods.

Sure, go ahead and push such changes.  I just went by what the rest of
indian.el input methods use.