From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Date: Sun, 25 Dec 2016 18:58:09 +0900 Message-ID: <87vau81gb2.fsf@gmail.com> References: <874m2q1oca.fsf@gmail.com> <4707af57-53ae-9b10-686a-1ca0864b9abb@yandex.ru> <87h96cr2su.fsf@secretsauce.net> <59e902d2-e8b4-63e3-f780-af24cdf50a74@yandex.ru> <9fe241fa-d4ee-6e44-bfdd-99cb6b4ab4e4@yandex.ru> <87fultr4he.fsf@secretsauce.net> <877f6v2vc1.fsf@gmail.com> <87inq8ec05.fsf@secretsauce.net> <871sww2vcf.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482659934 13980 195.159.176.226 (25 Dec 2016 09:58:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Dec 2016 09:58:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Tino Calancha , emacs-devel@gnu.org, Dmitry Gutov To: Dima Kogan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 25 10:58:47 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cL5Zl-0002kB-TN for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 10:58:46 +0100 Original-Received: from localhost ([::1]:46303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL5Zq-0006OL-GL for ged-emacs-devel@m.gmane.org; Sun, 25 Dec 2016 04:58:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cL5ZG-0006OE-SP for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:58:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cL5ZG-0005X8-2j for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:58:14 -0500 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:36336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cL5ZF-0005X2-TE for emacs-devel@gnu.org; Sun, 25 Dec 2016 04:58:14 -0500 Original-Received: by mail-pg0-x243.google.com with SMTP id n5so6052559pgh.3 for ; Sun, 25 Dec 2016 01:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=I5zKCUtThgB7rFRKkti6nRuG6F7icsVm1/BjOef6WwM=; b=Xk+GQUUKyw3YF2b0v4+NmjqLvcfRtoTN8dVE7BTzC0H/joKY3G5c/BFQmvE6c1feWC CwOOGU6AmpQ8BSveiOzIVuoL78oXWqRY5todfD8qAXWtjEkh9Pw39LEjniYidiyisN6T bLQvKphvItnTiT1LHid80ih6Y/tDO/hIjmMA1KAIwNltoWWrkGdv3U8AxJ8F65gp9qH6 DtRj1b9Q19K6qxS0AXSjvYkssEX3yEFDJOqLIc1o/8LzvijOU3cdchEn1LjC2nEztcpk GXH5WOf0xGN355jp0Ld/I1kK9NkQ8Yvq61GmRg7jDUr5o7enBY/1dX/T9xddlcrBR7fG e1Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=I5zKCUtThgB7rFRKkti6nRuG6F7icsVm1/BjOef6WwM=; b=a1ReaRb9TTXS3rFaVK+6aiNbSFe1+Gr7o0NSVkvwtxHbVLBXQilOexk4GxYAFrlpvg yicX09/+YXcdNdrslBEjYBJUmG47+IIKLJS9DZWVXvIF3ssvI94xI9xxLJYX0zht5c2r k01+TpbkKCLgI7dKSeJhk59CdzA6eoqatpIoEB30e4ggsGW8MXQxyYltMxLKQqoMvnUD 359hLwHSIp0uAZSGGyqTbhJG6AM2T0oPIdRQKs4Gcf6xoWbwIa+FL9H+OXGdoXy/+7M8 V9ekGe18QxmTWpkbskhoj6fwgNJBsRz9OHLjxsahALiLur+DhRSTDWC1Osf5jzqxcxl0 KoYw== X-Gm-Message-State: AIkVDXJgThrwim+u7y8erjuJkL/uyY30WS5v7qVhO9Ra6K0471WwDrszfMInEMObipKQYQ== X-Received: by 10.98.156.198 with SMTP id u67mr17605068pfk.109.1482659892887; Sun, 25 Dec 2016 01:58:12 -0800 (PST) Original-Received: from calancha-pc ([240f:6e:c111:1:87d4:550f:514f:c022]) by smtp.gmail.com with ESMTPSA id 24sm74190626pfh.41.2016.12.25.01.58.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Dec 2016 01:58:12 -0800 (PST) In-Reply-To: <871sww2vcf.fsf@gmail.com> (Tino Calancha's message of "Sun, 25 Dec 2016 18:48:00 +0900") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210800 Archived-At: Tino Calancha writes: >> Hi. I pushed to master the fix to this and the logic to invoke the >> auto-refinement only if the preceding motion was successful. > > Thank you. > I think is not working as before. > Consider following snippet code: > > M-! git show SHA1 RET > C-x b *Shell Command Output* RET > C-x C-q > M-x diff-mode > n > > When i use as SHA1 > e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97 > previous commands successfully move point to next hunk. > > But if i use commit > 6b6abe0dba6a9a2e5f78aac3814421886e7a184f > then they don't work; i got the following error: > user-error: No next hunk > > I am wondering why the second commit behaves differently than > the first one. In Emacs-25 the commit message is not considered part of the first hunk: So in the previous examples, the point is set in front of @@ -551,23 +551,7 @@ diff--auto-refine-data (for e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97) @@ -768,7 +768,7 @@ diff-beginning-of-file-and-junk (for 6b6abe0dba6a9a2e5f78aac3814421886e7a184f). After your changes the commit message is somehow part of the first hunk; then, from the beginning of buffer `n' will jump to the second hunk. This is unconvenient specially when the commit messages are long. I prefer the way this is handled in Emacs-25. Regards, Tino