From: Tino Calancha <tino.calancha@gmail.com>
To: Dima Kogan <lists@dima.secretsauce.net>
Cc: Tino Calancha <tino.calancha@gmail.com>,
emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation
Date: Sun, 25 Dec 2016 18:58:09 +0900 [thread overview]
Message-ID: <87vau81gb2.fsf@gmail.com> (raw)
In-Reply-To: <871sww2vcf.fsf@gmail.com> (Tino Calancha's message of "Sun, 25 Dec 2016 18:48:00 +0900")
Tino Calancha <tino.calancha@gmail.com> writes:
>> Hi. I pushed to master the fix to this and the logic to invoke the
>> auto-refinement only if the preceding motion was successful.
>
> Thank you.
> I think is not working as before.
> Consider following snippet code:
>
> M-! git show SHA1 RET
> C-x b *Shell Command Output* RET
> C-x C-q
> M-x diff-mode
> n
>
> When i use as SHA1
> e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97
> previous commands successfully move point to next hunk.
>
> But if i use commit
> 6b6abe0dba6a9a2e5f78aac3814421886e7a184f
> then they don't work; i got the following error:
> user-error: No next hunk
>
> I am wondering why the second commit behaves differently than
> the first one.
In Emacs-25 the commit message is not considered part of the
first hunk:
So in the previous examples, the point is set in front of
@@ -551,23 +551,7 @@ diff--auto-refine-data
(for e5ef59b87da5c2ddfa22f7342efe29b3eea6ed97)
@@ -768,7 +768,7 @@ diff-beginning-of-file-and-junk
(for 6b6abe0dba6a9a2e5f78aac3814421886e7a184f).
After your changes the commit message is somehow part
of the first hunk; then, from the beginning of buffer
`n' will jump to the second hunk. This is unconvenient
specially when the commit messages are long.
I prefer the way this is handled in Emacs-25.
Regards,
Tino
next prev parent reply other threads:[~2016-12-25 9:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 12:07 [Emacs-diffs] master 2c8a7e5: Improve diff-mode navigation/manipulation Tino Calancha
2016-11-30 0:03 ` Noam Postavsky
2016-11-30 14:22 ` Dmitry Gutov
2016-11-30 14:31 ` Stefan Monnier
2016-11-30 14:34 ` Dmitry Gutov
2016-11-30 15:07 ` Stefan Monnier
2016-12-10 1:27 ` Dima Kogan
2016-12-10 10:14 ` Dmitry Gutov
2016-12-10 17:27 ` Dima Kogan
2016-12-11 11:07 ` Dmitry Gutov
2016-12-12 7:28 ` Dima Kogan
2016-12-16 1:05 ` Dmitry Gutov
2016-12-20 2:22 ` Tino Calancha
2016-12-20 7:31 ` Dima Kogan
2016-12-25 6:52 ` Dima Kogan
2016-12-25 9:48 ` Tino Calancha
2016-12-25 9:58 ` Tino Calancha [this message]
2016-12-25 14:10 ` Dmitry Gutov
2016-12-06 2:03 ` Mark Oteiza
2016-12-07 7:29 ` Dima Kogan
2017-01-06 2:58 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vau81gb2.fsf@gmail.com \
--to=tino.calancha@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=lists@dima.secretsauce.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).