From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing "Unknown slot" warnings
Date: Sun, 29 Jan 2017 22:26:14 +0100 [thread overview]
Message-ID: <87vasx8snd.fsf@engster.org> (raw)
In-Reply-To: <jwvsho1hk6s.fsf-monnier+gmane.emacs.devel@gnu.org> (Stefan Monnier's message of "Sun, 29 Jan 2017 12:07:13 -0500")
Stefan Monnier writes:
>> After looking at the code, it seems all slot symbols are shoved into
>> `eieio--known-slot-names' and the byte-compiler checks if a slot is in
>> there, regardless of the class being used. So the following would
>> already do the trick:
>
>> (defmacro eieio-declare-slot (name)
>> "Declares slot to be available at runtime."
>> `(eval-when-compile (cl-pushnew ,name eieio--known-slot-names)))
>
> If you mean something to add to eieio, then yes, that's about right
> (tho you could also do it as (defmacro eieio-declare-slot (name)
> (cl-pushnew name eieio--known-slot-names) nil).
OK, I'll add that to EIEIO.
> My `defclass` solution was meant for use in code that must work with
> older Emacsen and/or older eieio without relying on internals like
> eieio--known-slot-names.
The new CEDET will only target the current master, so I finally don't
have to care about older Emacsen anymore.
-David
prev parent reply other threads:[~2017-01-29 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 12:39 Fixing "Unknown slot" warnings David Engster
2017-01-29 14:41 ` Stefan Monnier
2017-01-29 15:35 ` David Engster
2017-01-29 17:07 ` Stefan Monnier
2017-01-29 21:26 ` David Engster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vasx8snd.fsf@engster.org \
--to=deng@randomsample.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).