From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466) Date: Fri, 14 Apr 2017 02:35:08 +0300 Organization: LINKOV.NET Message-ID: <87vaq79903.fsf@localhost> References: <20170412194437.19648.75020@vcs0.savannah.gnu.org> <20170412194438.934FD22EE8@vcs0.savannah.gnu.org> <87shldl1v8.fsf@localhost> <83h91sizcn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1492126756 24978 195.159.176.226 (13 Apr 2017 23:39:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Apr 2017 23:39:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 14 01:39:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyoKU-0006Oz-TR for ged-emacs-devel@m.gmane.org; Fri, 14 Apr 2017 01:39:11 +0200 Original-Received: from localhost ([::1]:51274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyoKa-0007OM-MY for ged-emacs-devel@m.gmane.org; Thu, 13 Apr 2017 19:39:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyoJS-0006tn-Qh for emacs-devel@gnu.org; Thu, 13 Apr 2017 19:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyoJR-0000rQ-VL for emacs-devel@gnu.org; Thu, 13 Apr 2017 19:38:06 -0400 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:36075 helo=homiemail-a19.g.dreamhost.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyoJO-0000oc-46; Thu, 13 Apr 2017 19:38:02 -0400 Original-Received: from homiemail-a19.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTP id 3D0EE604084; Thu, 13 Apr 2017 16:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=jurta.org; bh=5HTzx2z cI6b/w9WBo7QZqGzH+PQ=; b=GvaZ3fl/gK1IAEzHOTo/PkrfWVTE90gA3h18oO5 /Sunp1UbH0Ezs8PKGR5y8m1oXoXW5UdUgwSv6qbFG25OIjPkNFyZLqPJ5so24Eg6 0Xf6eXzX365NgSkiLZ876y0Q9LKlK72/EWeQIuT9F3iIIdk2N3heKpiZiOk8kz/X 3XC8= Original-Received: from localhost.linkov.net (m90-133-225-157.cust.tele2.ee [90.133.225.157]) (Authenticated sender: jurta@jurta.org) by homiemail-a19.g.dreamhost.com (Postfix) with ESMTPA id 3D989604076; Thu, 13 Apr 2017 16:37:59 -0700 (PDT) In-Reply-To: <83h91sizcn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 13 Apr 2017 09:41:12 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213953 Archived-At: >> In any case it makes no sense to add special-casing for the minibuffer= in >> =E2=80=98kill-current-buffer=E2=80=99 since it is necessary only in =E2= =80=98kill-this-buffer=E2=80=99 >> associated with the tool-bar/menu-bar. > > Alas, a couple of users of kill-this-buffer were sometimes calling it > in the context of a menu-invoked command, so that part still can make > sense. And I have no idea which of the callers relied on this feature > even when invoking the function via non-menu events. It's been 9 > years since this feature was introduced. I'm sure that all these callers used kill-this-buffer because there was n= o kill-current-buffer to simply kill the current buffer, and nothing more. So I think we need to leave kill-this-buffer callers only in menu-bar/too= l-bar, and use kill-current-buffer everywhere else, leaving just =E2=80=98(kill-buffer (current-buffer))=E2=80=99 in the definition of kill-current-buffer in simple.el.