From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Tue, 09 May 2017 00:45:39 +0200 Message-ID: <87vapb9dd8.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> <83vapbctij.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494283602 21870 195.159.176.226 (8 May 2017 22:46:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 May 2017 22:46:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) Cc: mvoteiza@udel.edu, Eli Zaretskii , tino.calancha@gmail.com, emacs-devel@gnu.org To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 09 00:46:33 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7rQH-0005Wx-07 for ged-emacs-devel@m.gmane.org; Tue, 09 May 2017 00:46:33 +0200 Original-Received: from localhost ([::1]:34034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7rQM-0000z2-Je for ged-emacs-devel@m.gmane.org; Mon, 08 May 2017 18:46:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7rPZ-0000pQ-8M for emacs-devel@gnu.org; Mon, 08 May 2017 18:45:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7rPY-00087u-J9 for emacs-devel@gnu.org; Mon, 08 May 2017 18:45:49 -0400 Original-Received: from manu26.manufrog.com ([98.142.98.2]:48818) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d7rPU-00086A-2C; Mon, 08 May 2017 18:45:44 -0400 Original-Received: from c-f000e555.04-211-6c6b701.cust.bredbandsbolaget.se ([85.229.0.240]:54656 helo=muon.localdomain) by manu26.manufrog.com with esmtpa (Exim 4.88) (envelope-from ) id 1d7rPQ-0000hE-OV; Tue, 09 May 2017 00:45:40 +0200 Original-Received: by muon.localdomain (Postfix, from userid 1000) id A24EB48418C; Tue, 9 May 2017 00:45:39 +0200 (CEST) In-Reply-To: (Jean-Christophe Helary's message of "Tue, 9 May 2017 06:33:59 +0900") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - manu26.manufrog.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gnu.org X-Get-Message-Sender-Via: manu26.manufrog.com: authenticated_id: noreply@tryserumgardar.se X-Authenticated-Sender: manu26.manufrog.com: noreply@tryserumgardar.se X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 98.142.98.2 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214705 Archived-At: Jean-Christophe Helary writes: >> No, the issue is whether the function should enclose the argument in a >> grouping constructs of any kind, or should this be the caller's >> responsibility when the regexp includes \|. > > (split-string) in subr.el (line 3808) doesn't use grouping constructs > so why do something different than what's already the norm in an > official emacs lisp file? Doesn't that settle the issue? To me, that's nothing other than a bug: (split-string "abc, ;def g,hi" nil nil "[,;]") => ("abc" "def" "g,hi") ;; Should be equivalent! (split-string "abc, ;def g,hi" nil nil ",\\|;") => ("abc" "def" "g") ; BUG