* Warning "Obsolete name arg "password-store" to constructor auth-source-backend"
@ 2018-02-12 15:16 Alex Branham
2018-02-12 16:12 ` Clément Pit-Claudel
0 siblings, 1 reply; 4+ messages in thread
From: Alex Branham @ 2018-02-12 15:16 UTC (permalink / raw)
To: emacs-devel
Hi all -
I'm seeing the following warning when byte compiling
auth-password-store[1] on Emacs 26:
auth-password-store.el:82:1:Warning: Obsolete name arg "password-store" to
constructor auth-source-backend
Does anyone have any idea what this could mean or how to fix it? I
raised this in a github issue[2] and the package's authors seem as
perplexed as I am.
Any advice is appreciated!
Alex
Footnotes:
[1] https://github.com/DamienCassou/auth-password-store
[2] https://github.com/DamienCassou/auth-password-store/issues/54
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Warning "Obsolete name arg "password-store" to constructor auth-source-backend"
2018-02-12 15:16 Warning "Obsolete name arg "password-store" to constructor auth-source-backend" Alex Branham
@ 2018-02-12 16:12 ` Clément Pit-Claudel
2018-02-12 16:26 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Clément Pit-Claudel @ 2018-02-12 16:12 UTC (permalink / raw)
To: Alex Branham, emacs-devel; +Cc: Stefan Monnier
On 2018-02-12 10:16, Alex Branham wrote:
> Hi all -
>
> I'm seeing the following warning when byte compiling
> auth-password-store[1] on Emacs 26:
>
> auth-password-store.el:82:1:Warning: Obsolete name arg "password-store" to
> constructor auth-source-backend
>
> Does anyone have any idea what this could mean or how to fix it? I
> raised this in a github issue[2] and the package's authors seem as
> perplexed as I am.
Yes, see 2a61bd0096db23123734db439051c859e42b9606:
** EIEIO
…
*** The `newname' argument to constructors is optional&deprecated.
If you need your objects to be named, do it by inheriting from `eieio-named'.
It comes from passing "password-store" to auth-source-backend.
Looks like Damien silenced that warning in auth-source-pass.el:
(defvar auth-source-pass-backend
(auth-source-backend
(format "Password store")
:source "." ;; not used
:type 'password-store
:search-function #'auth-source-pass-search)
"Auth-source backend for password-store.")
… which seems OK to do, since all callers of auth-source-backend in auth-source.el do it? Maybe Stefan (who wrote that warning) can advise?
Clément.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Warning "Obsolete name arg "password-store" to constructor auth-source-backend"
2018-02-12 16:12 ` Clément Pit-Claudel
@ 2018-02-12 16:26 ` Stefan Monnier
2018-02-12 17:17 ` Alex Branham
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2018-02-12 16:26 UTC (permalink / raw)
To: Clément Pit-Claudel; +Cc: Alex Branham, emacs-devel
> (defvar auth-source-pass-backend
> (auth-source-backend
> (format "Password store")
> :source "." ;; not used
> :type 'password-store
> :search-function #'auth-source-pass-search)
> "Auth-source backend for password-store.")
>
> … which seems OK to do, since all callers of auth-source-backend in
> auth-source.el do it? Maybe Stefan (who wrote that warning)
> can advise?
Just remove that argument. It's unused.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: Warning "Obsolete name arg "password-store" to constructor auth-source-backend"
2018-02-12 16:26 ` Stefan Monnier
@ 2018-02-12 17:17 ` Alex Branham
0 siblings, 0 replies; 4+ messages in thread
From: Alex Branham @ 2018-02-12 17:17 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Clément Pit-Claudel, emacs-devel
Thanks for the help!
Alex
On Mon 12 Feb 2018 at 10:26, Stefan Monnier <monnier@IRO.UMontreal.CA> wrote:
>> (defvar auth-source-pass-backend
>> (auth-source-backend
>> (format "Password store")
>> :source "." ;; not used
>> :type 'password-store
>> :search-function #'auth-source-pass-search)
>> "Auth-source backend for password-store.")
>>
>> … which seems OK to do, since all callers of auth-source-backend in
>> auth-source.el do it? Maybe Stefan (who wrote that warning)
>> can advise?
>
> Just remove that argument. It's unused.
>
>
> Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-12 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-12 15:16 Warning "Obsolete name arg "password-store" to constructor auth-source-backend" Alex Branham
2018-02-12 16:12 ` Clément Pit-Claudel
2018-02-12 16:26 ` Stefan Monnier
2018-02-12 17:17 ` Alex Branham
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).