From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: comments about jsonrpc.el Date: Sun, 10 Jun 2018 12:39:45 +0100 Message-ID: <87vaaq6fb2.fsf@gmail.com> References: <87r2lqt3vz.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1528630681 17569 195.159.176.226 (10 Jun 2018 11:38:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2018 11:38:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Filipp Gunbin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 10 13:37:56 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fRyfU-0004Tz-0U for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2018 13:37:56 +0200 Original-Received: from localhost ([::1]:43632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRyhb-0002p4-2G for ged-emacs-devel@m.gmane.org; Sun, 10 Jun 2018 07:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRyhP-0002np-Sg for emacs-devel@gnu.org; Sun, 10 Jun 2018 07:39:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRyhL-0007Yc-53 for emacs-devel@gnu.org; Sun, 10 Jun 2018 07:39:54 -0400 Original-Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:38840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fRyhK-0007YD-T6 for emacs-devel@gnu.org; Sun, 10 Jun 2018 07:39:51 -0400 Original-Received: by mail-wr0-x236.google.com with SMTP id e18-v6so9246791wrs.5 for ; Sun, 10 Jun 2018 04:39:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ocZXeTqIUAnU46OcW38G8vxe+nKuM2dNXZUiMzDO95k=; b=c8HKziH5X7lrPMOAk7sZV58EiWaH5fzuXu1Rld5gPazAWeNsvEPlvoAzHZ3/gvFcBr UtfKXXitprscTJYsBJpSIP1yl5YzkmbJGwa0P7S5O1k8T7i/mdrkerjD1Sh3otRi3Khx goOAG3z7OoLrnW9sDuNyZqzjyPp/KhB0ZD+SRPTR+/cOtqQAFTqpZp1+Cihv+kb4YqNe aapfuZcFCwaeyL5qMGM34oENpwo/xJvXqRhmbhHBY8uC5xVbtP1hsN0WMmONpRUZ/nIS ji2/PRXUxEtJuAgthj+7bWccitptESveo7FMgFwYcl2Nt1zU2nah4nPm8hL+/eVJQqH4 ujgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ocZXeTqIUAnU46OcW38G8vxe+nKuM2dNXZUiMzDO95k=; b=Vea33aVG7tQD+9GmUkXipcpN9pOJk1xPD/nSLTq3ST5ryUqrCHpC3qmc7OcKPWnqPp KTcdPRhEqXStNMnO0z4fVM1Dc/gXmV3xZZO+Ftl83Oonkf1TIaXPLLHswOG43NzVM93d SSVTJo627KFmdOZ6yrKm1D5Y/iF8SRw5tLp/SLc0ZmuAx+/F2DSpwKIMjd9eXeYnTDwr CnneiUeUnEbjTSja9mov6AclLy0ZrTtgxzWBax52+tHyJAChKG9xGciVtyiuTv96uHV/ 2irPgnnxmUzjdOzWYwcpl5dtYmd29Js443zg4VfNZ4hURPaWDsVO+LyObNmGLhIMraxn iXIg== X-Gm-Message-State: APt69E0K9KYq2kg+cnkaEmrI/wiLxQT4dYjWnTjA8UC5NXbqLpzDWSK1 QTHlAvpV8Q1I450j2cacJhpGIPW0 X-Google-Smtp-Source: ADUXVKL63HHykFhmi0u83Tp8zGF9riqcq0RdpXkmNa8EhOiaj8ThffNTPzAkOub/SMBG8nPDpcHcDw== X-Received: by 2002:adf:b097:: with SMTP id i23-v6mr9631002wra.52.1528630789402; Sun, 10 Jun 2018 04:39:49 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id l41-v6sm74823004wre.87.2018.06.10.04.39.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Jun 2018 04:39:48 -0700 (PDT) In-Reply-To: (Filipp Gunbin's message of "Wed, 06 Jun 2018 23:43:46 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226164 Archived-At: Filipp Gunbin writes: >> No, it is (a) that is done, because we store the timer as the second >> element in (FN TIMER ID) pointed to by the deferred action. And we don't >> re-create the timer. > > But line 643 says '(setq timer (funcall make-timer)))' - isn't it what > gets into continuation? To be clear - I mean the timer which gets into > continuation (but if we re-defer deferred action - then yes, the > deferred action's timer is "inherited"). > Hi Filipp, In the newer version it doesn't say that, but even in that version I am pretty sure that `make-timer' was a lambda that checks the `timer` variable before actually making one. Jo=C3=A3o BTW, it's better to use diffs to highlight source code bits, it provides context, people do it quite extensively in this group. Also add the git commit hash (or if the code comes from an email, indicate the origin of the email )