Re: comments about jsonrpc.el

["João Távora" <joaotavora@gmail.com>]

Filipp Gunbin <fgunbin@fastmail.fm> writes:

>> No, it is (a) that is done, because we store the timer as the second
>> element in (FN TIMER ID) pointed to by the deferred action. And we don't
>> re-create the timer.
>
> But line 643 says '(setq timer (funcall make-timer)))' - isn't it what
> gets into continuation?  To be clear - I mean the timer which gets into
> continuation (but if we re-defer deferred action - then yes, the
> deferred action's timer is "inherited").
>
Hi Filipp,

In the newer version it doesn't say that, but even in that version I am
pretty sure that `make-timer' was a lambda that checks the `timer`
variable before actually making one.

João

BTW, it's better to use diffs to highlight source code bits, it provides
context, people do it quite extensively in this group.  Also add the git
commit hash (or if the code comes from an email, indicate the origin of
the email )