From: Michael Albinus <michael.albinus@gmx.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, emacs-devel@gnu.org
Subject: Re: some accept-process-output races fixed; Tramp FIXMEs
Date: Mon, 28 Jan 2019 16:37:10 +0100 [thread overview]
Message-ID: <87va28g5eh.fsf@gmx.de> (raw)
In-Reply-To: 6d537644-9b50-b71d-30a5-e8554e0b845c@cs.ucla.edu
Paul Eggert <eggert@cs.ucla.edu> writes:
> 0.1 is not merely suboptimal (i.e., slower than it should be), it's
> also incorrect (as it can sometimes lose data due to races). Even if
> we must use 0.1 in older Emacs to work around more-serious bugs there,
> we should use nil in Emacs master.
I've adapted all calls of accept-process-output to use a timeout of
either nil or 0. Running Tramp's test suite does not show relevant
performance differences for most of the backends, except smb. Here we
have a performance boost, (411.009675 sec before, 54.109701 sec after
the change).
The change works on all Emacsen 24-27, tested on GNU/Linux, with the
different backends. So I've taken the risk to apply it w/o compatibility
code. Let's see what people report.
I plan to test it also on OpenBSD and MS Windows, once I find respective
test machines. But this will happen for Emacs 27 only, I believe.
Best regards, Michael.
prev parent reply other threads:[~2019-01-28 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 18:33 some accept-process-output races fixed; Tramp FIXMEs Paul Eggert
2019-01-16 8:32 ` Michael Albinus
2019-01-16 8:38 ` Paul Eggert
2019-01-16 8:49 ` Michael Albinus
2019-01-16 13:03 ` Michael Albinus
2019-01-16 13:25 ` Stefan Monnier
2019-01-16 18:39 ` Paul Eggert
2019-01-16 19:07 ` Stefan Monnier
2019-01-17 0:15 ` Paul Eggert
2019-01-20 9:57 ` Michael Albinus
2019-01-21 23:02 ` Daniel Colascione
2019-01-22 16:54 ` Eli Zaretskii
2019-01-22 7:09 ` Paul Eggert
2019-01-22 16:56 ` Eli Zaretskii
2019-01-22 18:58 ` Michael Albinus
2019-01-22 22:06 ` Stefan Monnier
2019-01-22 22:45 ` Michael Albinus
2019-01-23 16:18 ` Eli Zaretskii
2019-01-23 18:35 ` Michael Albinus
2019-01-23 22:19 ` Daniel Pittman
2019-01-23 16:47 ` Stefan Monnier
2019-01-23 17:36 ` Paul Eggert
2019-01-28 15:37 ` Michael Albinus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va28g5eh.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).