[PATCH] * doc/misc/eshell.texi: Fix some @ref

[PATCH] * doc/misc/eshell.texi: Fix some @ref

[Gregor Zattler]

---
Dear emacs devs, I hope I did it right.  Ciao, Gregor

 doc/misc/eshell.texi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
index 3540707318..bf304bc17e 100644
--- a/doc/misc/eshell.texi
+++ b/doc/misc/eshell.texi
@@ -213,8 +213,8 @@ Invocation
 input line into a callable Lisp form.@footnote{To see the Lisp form that will be invoked, type: @samp{eshell-parse-command "echo hello"}}
 
 The command can be either an Elisp function or an external command.
-Eshell looks first for an @ref{Aliases, alias} with the same name as the
-command, then a @ref{Built-ins, built-in command} or a function with the
+Eshell looks first for an alias (@pxref{Aliases}) with the same name as the
+command, then a built-in (@pxref{Built-ins}) or a function with the
 same name; if there is no match, it then tries to execute it as an
 external command.
 
@@ -253,7 +253,7 @@ Built-ins
 @end example
 
 If you want to discard a given built-in command, you could declare an
-alias, @ref{Aliases}.  Example:
+alias, (@pxref{Aliases}).  Example:
 
 @example
 ~ $ which sudo
@@ -418,7 +418,7 @@ Built-ins
 
 @end table
 
-@ref{Aliases} for the built-in variables @samp{$*}, @samp{$1},
+@xref{Aliases} for the built-in variables @samp{$*}, @samp{$1},
 @samp{$2}, @dots{}, in alias definitions.
 
 @node Variables
@@ -629,8 +629,8 @@ Globbing
 Eshell's globbing syntax is very similar to that of Zsh.  Users coming
 from Bash can still use Bash-style globbing, as there are no
 incompatibilities.  Most globbing is pattern-based expansion, but there
-is also predicate-based expansion.  See
-@ref{Filename Generation, , , zsh, The Z Shell Manual}
+is also predicate-based expansion.  @xref{Filename Generation, , ,
+zsh, The Z Shell Manual}
 for full syntax.  To customize the syntax and behavior of globbing in
 Eshell see the Customize@footnote{@xref{Easy Customization, , , emacs,
 The GNU Emacs Manual}.}
-- 
2.11.0

Re: [PATCH] * doc/misc/eshell.texi: Fix some @ref

[Andreas Schwab]

On Feb 14 2019, Gregor Zattler <telegraph@gmx.net> wrote:

> @@ -253,7 +253,7 @@ Built-ins
>  @end example
>  
>  If you want to discard a given built-in command, you could declare an
> -alias, @ref{Aliases}.  Example:
> +alias, (@pxref{Aliases}).  Example:

I don't think there should be a comma before the paren.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

[PATCH v2] * doc/misc/eshell.texi: Fix some @ref (was: [PATCH] * doc/misc/eshell.texi: Fix some @refs)

[Gregor Zattler]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi Andreas, emacs developers,
* Andreas Schwab <schwab@linux-m68k.org> [2019-02-15; 09:20]:
> On Feb 14 2019, Gregor Zattler <telegraph@gmx.net> wrote:
>
>> @@ -253,7 +253,7 @@ Built-ins
>>  @end example
>>  
>>  If you want to discard a given built-in command, you could declare an
>> -alias, @ref{Aliases}.  Example:
>> +alias, (@pxref{Aliases}).  Example:
>
> I don't think there should be a comma before the paren.

I see.  Thanks for your close reading.  Version 2 is attached.

Ciao; Gregor

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-misc-eshell.texi-Fix-some-ref-v2.patch --]
[-- Type: text/x-diff, Size: 2133 bytes --]

>From f389902403221f33fb6293f789dd51336f13e20a Mon Sep 17 00:00:00 2001
From: Gregor Zattler <telegraph@gmx.net>
Date: Fri, 15 Feb 2019 10:25:18 +0100
Subject: [PATCH v2] * doc/misc/eshell.texi: Fix some @ref

---
 doc/misc/eshell.texi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
index 3540707318..bf304bc17e 100644
--- a/doc/misc/eshell.texi
+++ b/doc/misc/eshell.texi
@@ -213,8 +213,8 @@ Invocation
 input line into a callable Lisp form.@footnote{To see the Lisp form that will be invoked, type: @samp{eshell-parse-command "echo hello"}}
 
 The command can be either an Elisp function or an external command.
-Eshell looks first for an @ref{Aliases, alias} with the same name as the
-command, then a @ref{Built-ins, built-in command} or a function with the
+Eshell looks first for an alias (@pxref{Aliases}) with the same name as the
+command, then a built-in (@pxref{Built-ins}) or a function with the
 same name; if there is no match, it then tries to execute it as an
 external command.
 
@@ -253,7 +253,7 @@ Built-ins
 @end example
 
 If you want to discard a given built-in command, you could declare an
-alias, @ref{Aliases}.  Example:
+alias (@pxref{Aliases}).  Example:
 
 @example
 ~ $ which sudo
@@ -418,7 +418,7 @@ Built-ins
 
 @end table
 
-@ref{Aliases} for the built-in variables @samp{$*}, @samp{$1},
+@xref{Aliases} for the built-in variables @samp{$*}, @samp{$1},
 @samp{$2}, @dots{}, in alias definitions.
 
 @node Variables
@@ -629,8 +629,8 @@ Globbing
 Eshell's globbing syntax is very similar to that of Zsh.  Users coming
 from Bash can still use Bash-style globbing, as there are no
 incompatibilities.  Most globbing is pattern-based expansion, but there
-is also predicate-based expansion.  See
-@ref{Filename Generation, , , zsh, The Z Shell Manual}
+is also predicate-based expansion.  @xref{Filename Generation, , ,
+zsh, The Z Shell Manual}
 for full syntax.  To customize the syntax and behavior of globbing in
 Eshell see the Customize@footnote{@xref{Easy Customization, , , emacs,
 The GNU Emacs Manual}.}
-- 
2.11.0

Re: [PATCH v2] * doc/misc/eshell.texi: Fix some @ref (was: [PATCH] * doc/misc/eshell.texi: Fix some @refs)

[Eli Zaretskii]

> From: Gregor Zattler <telegraph@gmx.net>
> Date: Fri, 15 Feb 2019 10:26:25 +0100
> 
> >>  If you want to discard a given built-in command, you could declare an
> >> -alias, @ref{Aliases}.  Example:
> >> +alias, (@pxref{Aliases}).  Example:
> >
> > I don't think there should be a comma before the paren.
> 
> I see.  Thanks for your close reading.  Version 2 is attached.

Thanks, pushed.

You are getting close to the limit of the amount of changes we will be
able to accept from you without a copyright assignment.  Would you
like to start the legal paperwork towards an assignment?

Re: [PATCH v2] * doc/misc/eshell.texi: Fix some @ref (was: [PATCH] * doc/misc/eshell.texi: Fix some @refs)

[Gregor Zattler]

Hi Eli,
* Eli Zaretskii <eliz@gnu.org> [2019-02-16; 09:31]:
>> From: Gregor Zattler <telegraph@gmx.net>
>> Date: Fri, 15 Feb 2019 10:26:25 +0100
>> 
>> >>  If you want to discard a given built-in command, you could declare an
>> >> -alias, @ref{Aliases}.  Example:
>> >> +alias, (@pxref{Aliases}).  Example:
>> >
>> > I don't think there should be a comma before the paren.
>> 
>> I see.  Thanks for your close reading.  Version 2 is attached.
>
> Thanks, pushed.

Thanks.

> You are getting close to the limit of the amount of changes we will be
> able to accept from you without a copyright assignment.  Would you
> like to start the legal paperwork towards an assignment?

I sent REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES in April
last year but got no feedback.  I did again two minutes ago.



Ciao; Gregor
-- 
 -... --- .-. . -.. ..--.. ...-.-

Re: [PATCH v2] * doc/misc/eshell.texi: Fix some @ref (was: [PATCH] * doc/misc/eshell.texi: Fix some @refs)

[Eli Zaretskii]

> From: Gregor Zattler <telegraph@gmx.net>
> Date: Sat, 16 Feb 2019 17:55:55 +0100
> 
> > You are getting close to the limit of the amount of changes we will be
> > able to accept from you without a copyright assignment.  Would you
> > like to start the legal paperwork towards an assignment?
> 
> I sent REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES in April
> last year but got no feedback.  I did again two minutes ago.

Thanks.  If you don't get any response this time in two weeks, please
let me know.