From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Gramiak Newsgroups: gmane.emacs.devel Subject: Re: Replace XChar2b with unsigned in all font backends Date: Mon, 20 May 2019 12:14:44 -0600 Message-ID: <87v9y5uh63.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="147031"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 20:15:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSmoh-000c6Z-5f for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 20:15:19 +0200 Original-Received: from localhost ([127.0.0.1]:40006 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSmof-0006aW-TH for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 14:15:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSmo9-0006aJ-6R for emacs-devel@gnu.org; Mon, 20 May 2019 14:14:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSmo7-0004r6-WB for emacs-devel@gnu.org; Mon, 20 May 2019 14:14:45 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:32904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSmo7-0004qR-Hw for emacs-devel@gnu.org; Mon, 20 May 2019 14:14:43 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id y3so7103669plp.0 for ; Mon, 20 May 2019 11:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bA2Lqc1n3ahzQzdZ1Hole2t36X74ZY9ayl5YoFdW1Ts=; b=kBhfgXToMExJO42fz2F+AXxMKW3lGPwfc8XqOTL61f+unjch/uTQW5Aa9IA4uoj97v 5yMqJZLFzM6d8f6dwgKcRsYOxaD0r9jHSDRLm4bAH8dvwvod78gP9sHrF2YvHEvUkAEF iEm2XBU3ngh5xS92QHYheB7oVGI69+/jpBOpnW3HJTAdGKX/O+1MiXX6LCL8iF6NddFn 0pwfn+HrIDECNHxK7S+kloW/9ZUIoBxF3UjDpgRyqJmyMfgGCecKo2/1Sm8hRAijFCoZ lMpZULayQsHzRhe+RC0aDMZbZLYaGvnLrIjrW0l2HPQdOHltHQDoGptAfucxzya0QMno X63g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=bA2Lqc1n3ahzQzdZ1Hole2t36X74ZY9ayl5YoFdW1Ts=; b=ZzwS1JM9piuaONkLCVbLrs5zM4kR6Us2lOrO5ebjPYxq6iz2iyJyHKzX5Fd64TWxvg I6E+p+oYdUyHeR6Z9gkgf3fsIjXJ48RSuaG+6qhchBU2HExeWhVFq2M3dVmeGahfjQSV 8ODuOxEW7bD6qO4S9Heq1S5XD5dsJ7LJ1Y41+kawz1B035YoBhFQFn6S2WmkaZHWds7K UuF64AxMZuNDQ8w7+W1TDsDH8QOATpHydl/QAr5GvCN3WAmtb7gGAEPUVQf6x+iBfIAF wqkTLRzskqyll8MvX3EuOn3MHd7yJskbYmb/e94dup3k4O01Y0E9g96oUaAAvGEm2snd z5PQ== X-Gm-Message-State: APjAAAXYCJN3VcHw1fLM7Y3YpOuE/d9NUBWFQCyRjaaRLEP2RfHqbpnV YOzrqEQ35Ge6I29NcEaRVlFeqGfl X-Google-Smtp-Source: APXvYqxCbFQdvakEvjU1BUTE+whOVPbfIAP94t6xBrw7d0cHIcddhCyVebKeGRUjhjQUWUel6phg7A== X-Received: by 2002:a17:902:bb96:: with SMTP id m22mr77524012pls.5.1558376081370; Mon, 20 May 2019 11:14:41 -0700 (PDT) Original-Received: from lylat ([2604:3d09:e37f:1500:1a72:4878:e793:7302]) by smtp.gmail.com with ESMTPSA id n27sm39734377pfb.129.2019.05.20.11.14.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 11:14:40 -0700 (PDT) In-Reply-To: (Andy Moreton's message of "Mon, 20 May 2019 13:05:17 +0100") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::62f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236810 Archived-At: Andy Moreton writes: > Confirmed. This patch replaces use of XChar2b (a 16bit type) with > unsigned (usually 32bit) which seems wrong. > > AndyM I originally used unsigned short for this patch, but Eli[1] nudged me towards unsigned. Unsigned fits better with other parts of the font system, e.g., *encode_char returns unsigned, and *text_extents takes a pointer to unsigned. [1] https://lists.gnu.org/archive/html/emacs-devel/2019-05/msg00457.html