From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: search-default-mode char-fold-to-regexp and Greek Extended block characters
Date: Fri, 26 Jul 2019 21:40:58 +0300 [thread overview]
Message-ID: <87v9vozrjn.fsf@mail.linkov.net> (raw)
In-Reply-To: <8336itnxgv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 09:04:00 +0300")
>> > But this one I donʼt understand. Searching for iota (capital or small)
>> > in a buffer containing ΐ ΐ or Ϊ́ already works with
>> > char-fold-to-regexp, so why is this needed?
>>
>> Searching for ι finds ΐ only when searching for a single letter ι
>> because the search matches the first part of ΐ that contains the base
>> character ι and ignores the remaining combining accents like ̈́
>>
>> So for testing you need to search for longer strings, e.g.
>> in a buffer with this text "ΐΐΪ́." try to search for "ιιι."
>>
>> It fails to find this text without adding (?ι "ΐ")
>> to char-fold-include.
>
> Maybe we should decide that this is a limitation of the current
> implementation, and instead work on a more correct implementation,
> which actually "folds" characters to their base variants as the search
> proceed.
>
> Let's not forget that the current implementation was known to be
> limited from the get-go, and we only accepted it because the "full"
> one was too complex and required non-trivial changes on the C level.
> So we shouldn't go too far into making the current implementation
> support everything that the full one will inherently support.
I consider the current regexp-based implementation as a fully functional
prototype with complete test coverage, so after switching the
implementation later to C, the same tests should still pass.
next prev parent reply other threads:[~2019-07-26 18:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 14:18 search-default-mode char-fold-to-regexp and Greek Extended block characters Robert Pluim
2019-07-19 14:37 ` Eli Zaretskii
2019-07-19 16:03 ` Robert Pluim
2019-07-19 18:13 ` Eli Zaretskii
2019-07-21 11:03 ` Robert Pluim
2019-07-22 18:39 ` Robert Pluim
2019-07-23 14:57 ` Eli Zaretskii
2019-07-23 17:43 ` Robert Pluim
2019-07-23 20:29 ` Juri Linkov
2019-07-24 7:56 ` Robert Pluim
2019-07-24 7:59 ` Robert Pluim
2019-07-24 9:04 ` Robert Pluim
2019-07-24 23:12 ` Juri Linkov
2019-07-25 0:18 ` Basil L. Contovounesios
2019-07-25 18:40 ` Juri Linkov
2019-07-25 20:44 ` search-default-mode char-fold-to-regexp and Greek Extended block characters, " Robert Pluim
2019-07-25 21:35 ` Juri Linkov
2019-07-26 11:09 ` Robert Pluim
2019-07-26 18:38 ` Juri Linkov
2019-07-29 8:32 ` Robert Pluim
2019-07-29 18:09 ` Juri Linkov
2019-07-30 8:09 ` Robert Pluim
2019-07-30 10:15 ` Eli Zaretskii
2019-07-25 2:36 ` Eli Zaretskii
2019-07-25 8:59 ` Robert Pluim
2019-07-25 12:53 ` Eli Zaretskii
2019-07-25 8:46 ` Robert Pluim
2019-07-25 18:46 ` Juri Linkov
2019-07-26 6:04 ` Eli Zaretskii
2019-07-26 18:40 ` Juri Linkov [this message]
2019-07-26 19:13 ` Eli Zaretskii
2019-07-19 18:53 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9vozrjn.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).