From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: master c59e878: Inhibit modification hooks when saving eieio-persistent's Date: Sun, 03 May 2020 07:13:50 +0200 Message-ID: <87v9ldfvn5.fsf@web.de> References: <20200501192115.23847.67499@vcs0.savannah.gnu.org> <20200501192116.A55EE20B5B@vcs0.savannah.gnu.org> <87368jba7f.fsf@web.de> <87y2qb9tv3.fsf@web.de> <87tv0z9qt2.fsf@web.de> <87bln611vs.fsf@web.de> <87a72p7n4v.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="84664"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , emacs-devel@gnu.org To: Eric Abrahamsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 03 07:17:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jV6zs-000Lsc-IC for ged-emacs-devel@m.gmane-mx.org; Sun, 03 May 2020 07:17:00 +0200 Original-Received: from localhost ([::1]:54590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jV6zr-0007Yh-Ab for ged-emacs-devel@m.gmane-mx.org; Sun, 03 May 2020 01:16:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jV6x5-0005qE-9u for emacs-devel@gnu.org; Sun, 03 May 2020 01:14:07 -0400 Original-Received: from mout.web.de ([212.227.15.3]:54051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jV6x4-0005s8-21 for emacs-devel@gnu.org; Sun, 03 May 2020 01:14:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588482832; bh=x5lqmTCiNXK9ubUqxKu8A+urLc65kHb/RjKzkTk4qRI=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=YiPdTcG3ffBACSyYAB6J99flLtDN5WDg3nKjHJjAJooFH7hmxe9I9ig3UWNVAlRnv 1rSnK+TmmpS7GGT5bBUbedLMgh2Hv61NIFMfhYeQwT+lVEsfRUzhpQz5hPbIirMGdc RIiunbHEdvlmUUcgSYmRkV4yQd1AAOe5Yuh6wHCE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([188.99.168.6]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LzsHL-1j8vAy42bL-0150uP; Sun, 03 May 2020 07:13:52 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 03 May 2020 00:01:01 -0400") X-Provags-ID: V03:K1:FrHNhu4tr/sRaAhk3oI/Z1H/B+H5IDtDb9OuFfXPKSqMZnTnw4j PP9x+PEgGJj/owYliSGfFEgLz/SdQl9e+EptiXdWZhcFJ2G24cV7/c2wYUxtq0YtiO0ZS2i fXydp4y4qCBjoRzUus/ZZw5silA/l22SSftV/CxyPNnL7z45aYQA0K2OqZHUa7M5uHqMFAb nxuJZUMsfaqWzcW82MaQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:y7p6VBESTxc=:aLXZNNl2TdWXeHRHlNWpm3 qgHKV6MXDuPWIZXNF9uG73BlOJpzq5tAZEFbZaKz8ryw1IGN06Bd+wVKPa17lRv00AbTyD1uu 10zxfKGf3P+T6EdS/sQk8/+/qqKMEbzTIM+Wjv5tmm0K2nEkwFLgygFIx7fbTz3SxgIpO49Sr hmVVOfiC4P5zjJhHYaS5cWQn20xAa2rbfGMIrtENlRuZuv2KZh5mJkDXewQ/HhILX61sCx4rU zDoM1aTjK7RLp0HF8m98wjPC9iRlcusCRpGJ343QMQB/jeBwXy3GMOrs4HrntM6AbYF6FxtTN ylvAdBFUa6l2AVNTPKyV6BW4OZ/pN3ou8emK3HiOINy18D7HCMf1OL4BB+mcDV8WQU2bzL/A2 F6NRTKEEQrFWHUwCmS0Dc276CTgCM1GWGEu2lgd15v6MBj+HcE1eTcfO3vomwtZyYRNG7L5i/ 9f90gvDjpgV48a2LVR9RASKl4NIFZCM8KeOuiBYRywfcrarXxnfaTfHs/8onqIP10Iq5d0Aiy AZC0LPObPRwP1YnCZiCbHfuUldxplzDFDFdbP7I5/QCw3CXbs8N3a5xECU8XHtnJBmmO/EKPT h6IyZ3W/H7CQSup4Gnzw15ehIBzdy5UjgS6159R9A/Kigmzaks6qaKHxjYBsyaaVZCRZUa7pC Y5aLVhp4iZE/c/5jYV+EBHN4rB/NA0aI7TQlkKPmybqnuRKcN5N+mtq+WgxeNhZdJx+LW+WZw DL9rNGBd1bUziy+SMZMbUNJJkIZFXUQ5Sik1CY7X5+IYaP1kyF22njYW14ffmnIgiMOGsCNV Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/03 01:14:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248638 Archived-At: Stefan Monnier writes: > > After having identified the culprits in my case - all of them can be > > fixed - there is not much speedup left from this particular change. > > Given that, but also given that we don't know what other people might > > have added there - do you think that using `combine-change-calls' in > > this case is justified, Stefan? > > I hope not ;-) Then Eric I think it's your turn now to check (profile) if this is at all helpful in your case. Could you please try that? Thanks, Michael.