From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.devel Subject: Re: Slot accessing issues in EIEIO Date: Wed, 06 May 2020 18:43:07 +0200 Message-ID: <87v9l9ypyc.fsf@bernoul.li> References: <87a72lhf3b.wl-all_but_last@163.com> <871rnx131x.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="28428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Zhu Zihao , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 06 18:45:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWNBE-0007IA-Gd for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 18:45:56 +0200 Original-Received: from localhost ([::1]:35394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWNBD-0005lW-8b for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 12:45:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWN8Z-00056i-2t for emacs-devel@gnu.org; Wed, 06 May 2020 12:43:11 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:41106) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWN8X-0003cb-Vd for emacs-devel@gnu.org; Wed, 06 May 2020 12:43:10 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id DD431165C7; Wed, 6 May 2020 18:43:07 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id Nx9Y5AjKShbl; Wed, 6 May 2020 18:43:07 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 6FDCE165C3; Wed, 6 May 2020 18:43:07 +0200 (CEST) In-Reply-To: Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/06 11:40:56 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249099 Archived-At: Stefan Monnier writes: >>>> Recently, I'm reading the source of >>>> closql(https://github.com/emacscollective/closql), A Emacs sqlite database ORM >>>> package. It use eieio object, and put a piece of advice on eieio-oref to >>>> intercept the reading slot action. >>> >>> Yuck! Can you explain why they need an advice on `eieio-oref`? >> >> A right. That's one of the reasons I never bothered to get eieio >> changed to better accommodate my extension; I expected a negative >> reaction like this. > > Note the "Yuck" is about putting an advice on such a core function. > Not about the functionality that it provides (over which I don't have > an opinion yet since I don't know what it does). > > IOW the "yuck" is saying "please request an extension so it can be > better accomodated" ;-) Okay understood. I guess I was feeling a bit insecure about having written a ORMish thing in first place, and was a bit over sensitive because of that. ;D