unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: master 7496690: ; Clean up recent project.el additions
Date: Wed, 03 Jun 2020 14:37:42 +0100	[thread overview]
Message-ID: <87v9k8z2vt.fsf@tcd.ie> (raw)
In-Reply-To: <de96413d-1632-93a7-12a4-d8bd4ec55e25@yandex.ru> (Dmitry Gutov's message of "Wed, 3 Jun 2020 14:49:42 +0300")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 03.06.2020 13:56, Basil L. Contovounesios wrote:
>>   (defgroup project nil
>>     "Operations on the current project."
>> +  :version "28.1"
>
> I'm wasn't sure about adding this :version tag. Would it imply the whole package
> was only added in 28.1?

No, because a customisation group is not a package.  I'm not actually
aware of any places where defgroup/defface/etc. :version tags are
currently used, but since Glenn put some effort into adding them[1], I
think project.el should continue to use them consistently.

[1]: Add some missing version tags.
e85e0d5951 2016-01-12 20:06:49 -0500
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=e85e0d5951bd4e6e69beec1301113f5f9b48f81d

> It also create a kind of curious situation when a subgroup was added earlier
> than the parent group. :-)

The :version tag can also indicate "was changed in some notable way," so
I don't think that matters too much, and as I said I don't think the
information is currently used anywhere.

-- 
Basil



      reply	other threads:[~2020-06-03 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200603105637.26434.62647@vcs0.savannah.gnu.org>
     [not found] ` <20200603105638.D04DB20A26@vcs0.savannah.gnu.org>
2020-06-03 11:49   ` master 7496690: ; Clean up recent project.el additions Dmitry Gutov
2020-06-03 13:37     ` Basil L. Contovounesios [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9k8z2vt.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).