From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Sun, 13 Sep 2020 22:17:19 +0300 Organization: LINKOV.NET Message-ID: <87v9ghlc5c.fsf@mail.linkov.net> References: <87mu1xrjqw.fsf@gkayaalp.com> <48ed4897-356c-4669-a330-1fdb5d65402b@default> <83lfhhijbl.fsf@gnu.org> <871rj9uz12.fsf@gkayaalp.com> <875z8k4wv8.fsf@posteo.net> <83pn6shjni.fsf@gnu.org> <20200911074445.GB5194@tuxteam.de> <87zh5uqdqm.fsf@mail.linkov.net> <834ko1da33.fsf@gnu.org> <87sgbloe5z.fsf@mail.linkov.net> <83een5bkja.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: tomas@tuxteam.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 13 21:20:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHXXk-000A4h-31 for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 21:20:08 +0200 Original-Received: from localhost ([::1]:36692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHXXi-0002q8-Tw for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Sep 2020 15:20:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXX9-0002Ps-Np for emacs-devel@gnu.org; Sun, 13 Sep 2020 15:19:31 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:48505) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHXX7-00072g-E2; Sun, 13 Sep 2020 15:19:31 -0400 X-Originating-IP: 91.129.97.241 Original-Received: from mail.gandi.net (m91-129-97-241.cust.tele2.ee [91.129.97.241]) (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 90F4D40006; Sun, 13 Sep 2020 19:19:23 +0000 (UTC) In-Reply-To: <83een5bkja.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Sep 2020 21:26:17 +0300") Received-SPF: pass client-ip=217.70.183.194; envelope-from=juri@linkov.net; helo=relay2-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/13 13:34:55 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255563 Archived-At: >> + (tool-bar-add-item "newsticker/narrow" > > This doesn't exactly look like a Hamburger menu icon... Really? Maybe someone could help to draw a real hamburger. > Also, we'd like to have this at the right edge of the tool bar, where > users will expect it, I think. IDK, some programs display it on the left, some on the right. Anyway, there is a bug in tool-bar code that doesn't allow to use align-to, whereas align-to works perfectly when used on the tab-bar. Here is the test case to reproduce the bug on the tool-bar: emacs -Q and eval: (define-key-after (default-value 'tool-bar-map) [global-menu-bar] `(menu-item (propertize " " 'display '(space :align-to (- right 5))) (lambda () (interactive) (popup-menu (mouse-menu-bar-map))) :image ,(tool-bar--image-expression "newsticker/narrow") :help "Pop up the global menu bar")) (force-mode-line-update) It doesn't align the icon to the right edge of the tool-bar whereas the same code aligns it on the tab-bar.