From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Fri, 22 Jan 2021 00:32:38 +0200 Organization: LINKOV.NET Message-ID: <87v9bp7wft.fsf@mail.linkov.net> References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16415"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 21 23:34:22 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l2iX0-0004AW-GQ for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jan 2021 23:34:22 +0100 Original-Received: from localhost ([::1]:33622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2iWz-00070z-EX for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jan 2021 17:34:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2iWE-0006c0-28 for emacs-devel@gnu.org; Thu, 21 Jan 2021 17:33:34 -0500 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:49459) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2iWA-0000FL-Ns for emacs-devel@gnu.org; Thu, 21 Jan 2021 17:33:32 -0500 X-Originating-IP: 91.129.98.64 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id AB3BD20007; Thu, 21 Jan 2021 22:33:25 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 21 Jan 2021 17:01:12 -0500") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263261 Archived-At: >>> It seems the right fix is to change the format of the >>> "Unknown defun property" warning to the same format >>> whose highlighting is already supported, i.e. with >>> >>> filename:line-number:column-number: Warning: Unknown defun property >> >> But the problem is that filename is unknown here. > > Traditionally, you can work around this by using "" or > "" or some such pseudo-filename. Then maybe to use a function name as a file name? diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 0f8dd5a284..619bcf9278 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -301,8 +301,9 @@ defun (cdr body) body))) nil) - (t (message "Warning: Unknown defun property `%S' in %S" - (car x) name))))) + (t (message "%S:%d:Warning: Unknown defun property `%S'" + name (count-lines (point-min) (point)) + (car x)))))) decls)) (def (list 'defalias (list 'quote name)