unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Daphne Preston-Kendal <dpk@nonceword.org>
Cc: emacs-devel@gnu.org
Subject: Re: Detecting changes between dark and light mode on Mac OS
Date: Mon, 22 Mar 2021 21:07:53 +0100	[thread overview]
Message-ID: <87v99jeyue.fsf@gnus.org> (raw)
In-Reply-To: <3B7287EE-B559-4E3B-A24E-7ABD71EFEB6F@nonceword.org> (Daphne Preston-Kendal's message of "Sun, 21 Mar 2021 11:22:43 +0100")

Daphne Preston-Kendal <dpk@nonceword.org> writes:

> Okay, well, if there are plans to support similar functionality
> cross-platform, surely it’s okay to add it just for Mac OS for now?
> There’s already quite a few Mac OS specific features in nsterm.m and
> nsfns.m. The ns-appearance property on frames, which already provides
> a limited form of integration with this Mac OS feature (you can set
> the theme to light or dark on a per-frame basis, but it doesn’t tell
> you what the system sets it to by default, which my patch fixes) is
> one of them!

Some non-free system specific things have snuck in over the years, but
we try not to.

> Or is your suggestion that I simply rename this hook to
> dark-mode-changed-hook without the ns- prefix, notwithstanding that it
> doesn’t currently work on any platform other than Mac OS?

No, the project policy is that features like this should also have an
implementation on free systems, too, before support for non-free systems
are added, unfortunately.

So support for dark mode on GNU/Linux has to be added first (or at the
same time).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2021-03-22 20:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 13:23 Detecting changes between dark and light mode on Mac OS Daphne Preston-Kendal
2021-03-20 16:51 ` Daphne Preston-Kendal
2021-03-20 17:52   ` Alan Third
2021-03-21 11:01     ` Daphne Preston-Kendal
2021-03-21  7:01   ` Lars Ingebrigtsen
2021-03-21 10:22     ` Daphne Preston-Kendal
2021-03-22 20:07       ` Lars Ingebrigtsen [this message]
2021-03-23 18:32         ` chad
2021-03-23 17:49     ` Matt Armstrong
2021-03-24  8:30       ` Lars Ingebrigtsen
2021-03-25 16:33         ` Stefan Monnier
2021-03-28  1:16           ` chad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v99jeyue.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=dpk@nonceword.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).