From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: Simple isearch concerns Date: Sun, 25 Apr 2021 09:15:43 +0200 Message-ID: <87v98asulc.fsf@gmail.com> References: <20210403001539.x4rb55dvh46rmhb3.ref@Ergus> <20210403001539.x4rb55dvh46rmhb3@Ergus> <2599ffef-4f70-025c-5f9c-61b9ac94faf8@inventati.org> <87eefrbo9k.fsf@posteo.net> <7473b27b2b479f5686af@heytings.org> <87tuon9vf1.fsf@posteo.net> <20210403174508.xwr5uc36dzityitn@Ergus> <87wnsurdr7.fsf@gmail.com> <87fszij6to.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: Ergus , Gregory Heytings , Manuel Uberti , Philip Kaludercic , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 25 09:39:46 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1laZMo-0005C9-02 for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 09:39:46 +0200 Original-Received: from localhost ([::1]:43024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laZMm-0008NM-MG for ged-emacs-devel@m.gmane-mx.org; Sun, 25 Apr 2021 03:39:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laYzh-0001UB-Cx for emacs-devel@gnu.org; Sun, 25 Apr 2021 03:15:53 -0400 Original-Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:34455) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laYzf-0006MD-Ja for emacs-devel@gnu.org; Sun, 25 Apr 2021 03:15:53 -0400 Original-Received: by mail-ej1-x630.google.com with SMTP id n21so3520054eji.1 for ; Sun, 25 Apr 2021 00:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Qtg0ku0ujenulHSPhZv4ZARoGLhlo2r/a0SfIoj9eEE=; b=LZE7SJmDLhLNQEsy4QJD+EHZOUaW5qtEz93OPuHDHnEuaDj79vZcIog7BCO9hcSart i6WsQ2CbAXVof6Z/r6htEs9hb3T0JN6ktLn2oi5Q0iVuCxpc/vDaNH7FBMOYxSPf3YLB CxIO7tyoOpVUUFGs0vxRCS2No7mbVWhNsShAhJ7rgFRYMABfhujpTVhYT8WVr+pAyn2C UTjW+rts7fbqsRJSmEJT18y2cgci1qBcNtCkOJeRYN5KcOOKBX7IrFWh72/LrHjrwk6w G/riPMMA3Y46tG6LqLE5k9Bi58Br+wps6I62sRELmbpli+aC+xhipJ+Ldtrf7TV6qzM1 wMLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Qtg0ku0ujenulHSPhZv4ZARoGLhlo2r/a0SfIoj9eEE=; b=TWuy9dQfnxasxH6YrvD39W51FVTL1CdjKhzhjTuU7mR8luvnAShgYEFFgloMt+aquj PhFg/QY6qd1MEmEZkh11OvPA+RyE4iKGNHxOsUQk/HBc2yIWKMSA1BjpJZg/aYSw2+8J CusZO3ibsHBadHLI8C9Lwz9fh4uerNA0C4vXg89hJHr+3UBCYNwQ4Yh/4aRK6NlfvEep aFT3UqRt3FTYsjs+fcMniREkTf0FpLmJa6BFS2ZsR/Ayr+ZZn65uruhs5EkXg0DLJ5U1 N2Tz2HugZta4Btf4pu8J+34cjqippOAK6c/qAmXNSOs4M81LqdZ7E+fsCQ8bLEhh83E+ sTEQ== X-Gm-Message-State: AOAM533E8XxZOMKlCAIW04GdaNbEZb2j6L0RsGFr+d3XdNb/B0NyKSv5 BuSxA7sudQe12jwoPFiR/qO2STER3tEtEg== X-Google-Smtp-Source: ABdhPJx/3ozGSLCHMASbrDXNLH8uR89FS64N888Gx92FonpVldxBTSHclOW3CqWhfUx0ZUo0zPPzfQ== X-Received: by 2002:a17:906:c04:: with SMTP id s4mr12378712ejf.410.1619334944854; Sun, 25 Apr 2021 00:15:44 -0700 (PDT) Original-Received: from ars3 ([2a02:908:2211:8540::68a]) by smtp.gmail.com with ESMTPSA id n21sm3542905ejx.74.2021.04.25.00.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 00:15:44 -0700 (PDT) In-Reply-To: <87fszij6to.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 23 Apr 2021 01:24:51 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 25 Apr 2021 03:37:37 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268358 Archived-At: On Fri, 23 Apr 2021 at 01:24, Juri Linkov wrote: > Nice idea. Like TAB typed in the minibuffer updates the Completions buffer, > C-s typed in the isearch-edit-string minibuffer could update the matches > in the searched buffer. Do you think this feature could make it into isearch.el, or would make more sense as an external package? You can take a look at the git repo linked in my previous message to get a sense of how the implementation would look like. In isearch.el itself, one would have to introduce a new macro `(with-current-search-buffer ...)' and wrap the body of every relevant interactive command in it (similar to the `isearch-mb--with-buffer' advice in my package sketch). Then there's also the case of commands start or end a search, which need special treatment. I'm not sure this can be made to work perfectly in every use case, or not break some third party packages and user configurations. It certainly can be made to work well enough for those who find the normal Isearch a bit too eccentric.